From owner-svn-src-head@FreeBSD.ORG Tue Aug 21 23:26:15 2012 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DB1C81065673; Tue, 21 Aug 2012 23:26:15 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from exprod7og110.obsmtp.com (exprod7og110.obsmtp.com [64.18.2.173]) by mx1.freebsd.org (Postfix) with ESMTP id CA3EB8FC1C; Tue, 21 Aug 2012 23:26:11 +0000 (UTC) Received: from P-EMHUB03-HQ.jnpr.net ([66.129.224.36]) (using TLSv1) by exprod7ob110.postini.com ([64.18.6.12]) with SMTP ID DSNKUDQZDQ8Y6OQwfaPLyzQPy9Db3Bt0vfTX@postini.com; Tue, 21 Aug 2012 16:26:14 PDT Received: from magenta.juniper.net (172.17.27.123) by P-EMHUB03-HQ.jnpr.net (172.24.192.33) with Microsoft SMTP Server (TLS) id 8.3.213.0; Tue, 21 Aug 2012 16:25:53 -0700 Received: from chaos.jnpr.net (chaos.jnpr.net [172.24.29.229]) by magenta.juniper.net (8.11.3/8.11.3) with ESMTP id q7LNPrh29756; Tue, 21 Aug 2012 16:25:53 -0700 (PDT) (envelope-from sjg@juniper.net) Received: from chaos.jnpr.net (localhost [127.0.0.1]) by chaos.jnpr.net (Postfix) with ESMTP id 35D4F58085; Tue, 21 Aug 2012 16:25:53 -0700 (PDT) To: Jilles Tjoelker In-Reply-To: <20120821222943.GA27203@stack.nl> References: <201207180557.q6I5vheM034018@svn.freebsd.org> <20120726084903.GA48240@lo0.su> <20120821053519.BD5A158085@chaos.jnpr.net> <20120821222943.GA27203@stack.nl> Comments: In-reply-to: Jilles Tjoelker message dated "Wed, 22 Aug 2012 00:29:44 +0200." From: "Simon J. Gerraty" X-Mailer: MH-E 7.82+cvs; nmh 1.3; GNU Emacs 22.3.1 Date: Tue, 21 Aug 2012 16:25:53 -0700 Message-ID: <20120821232553.35D4F58085@chaos.jnpr.net> MIME-Version: 1.0 Content-Type: text/plain Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, "David E. O'Brien" , sjg@juniper.net, Ruslan Ermilov , svn-src-head@FreeBSD.org Subject: Re: svn commit: r238563 - head/gnu/usr.bin/groff/tmac X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2012 23:26:16 -0000 On Wed, 22 Aug 2012 00:29:44 +0200, Jilles Tjoelker writes: >On FreeBSD, the first two statements are partially false. All sh(1) >builtins that correspond to utilities specified by POSIX (but not >special builtins) have versions accessible to execve() (on 8.x and That's interesting, especially for 'cd', though is there any use case in which it is actually useful? I'm drawing a blank. >older, hash, type and ulimit are missing). This includes cd but not >chdir, since chdir is not specified by POSIX. Also, FreeBSD make >includes a somewhat arbitrary list of shell builtins, including cd, that >cause it to invoke the shell even if there are no metacharacters. Yes, I pondered whether something like that might be worthwhile, but since a bare 'cd somewhere' all by itself is rather pointless, it seemed a corner case. >> A better way to construct targets like this is to put any excursion out >> of .OBJDIR inside (): > >> (cd ${.CURDIR} && \ >> ${INSTALL} -o ${TMACOWN} -g ${TMACGRP} -m ${TMACMODE} \ >> koi8-r.tmac hyphen.ru ${DESTDIR}${TMACDIR}) > >> then the cd ${.OBJDIR} isn't needed at all. >> note use of && rather than ; which can be very dangerous > >This method makes more sense and should hardly cost any performance. Agreed.