From owner-freebsd-current@freebsd.org Sat Oct 17 14:44:34 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 58689A1727F for ; Sat, 17 Oct 2015 14:44:34 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 40F6411B5; Sat, 17 Oct 2015 14:44:34 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id 3A38814BF; Sat, 17 Oct 2015 14:44:34 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id E3FD314C40; Sat, 17 Oct 2015 14:44:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id fQehgKXd1c0C; Sat, 17 Oct 2015 14:44:31 +0000 (UTC) Content-Type: text/plain; charset=utf-8 DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 025DB14C3C Mime-Version: 1.0 (1.0) Subject: Re: FreeBSD_HEAD_amd64_gcc4.9 - Build #673 - Failure From: Bryan Drewery X-Mailer: iPhone Mail (12H143) In-Reply-To: Date: Sat, 17 Oct 2015 07:44:27 -0700 Cc: Garrett Cooper , "jenkins-admin@FreeBSD.org" , "freebsd-current@FreeBSD.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <1743862498.27.1445058611319.JavaMail.jenkins@jenkins-9.freebsd.org> <5621D9F1.9080707@FreeBSD.org> <5621DDB1.8020807@FreeBSD.org> <31F4FEC4-B677-4EA1-BD67-F2DC458A99E4@gmail.com> <2B9A4B89-6D0D-4549-B249-FB30A8117DDF@gmail.com> <78883694-7B54-4AC3-9B5B-D715D5DA1F88@gmail.com> To: Dimitry Andric X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Oct 2015 14:44:34 -0000 > On Oct 17, 2015, at 04:11, Dimitry Andric wrote: >=20 >> On 17 Oct 2015, at 09:09, NGie Cooper wrote: >> ... >> Also, this logic looks troublesome: >>=20 >> 42 .if empty(TOOLSDIR) || !exists(${TOOLSDIR}/usr/bin/clang-tblgen) >> 43 .if ${MACHINE} =3D=3D "host" && defined(BOOTSTRAPPING_TOOLS) >> 44 .if !empty(LEGACY_TOOLS) && exists(${LEGACY_TOOLS}/usr/bin/tblgen) >> 45 TOOLSDIR=3D ${LEGACY_TOOLS} >> 46 .endif >> 47 .endif >> 48 .if ${MK_STAGING} =3D=3D "yes" && exists(${STAGE_HOST_OBJTOP:Uno}/usr/= bin/tblgen) >> 49 TOOLSDIR=3D ${STAGE_HOST_OBJTOP} >> 50 .endif >> 51 .if exists(${LEGACY_TOOLS:Uno}/usr/bin/tblgen) >> 52 TOOLSDIR=3D ${LEGACY_TOOLS} >> 53 .endif >> 54 .endif >> 55 TOOLSDIR?=3D >> 56 .if !empty(TOOLSDIR) && exists(${TOOLSDIR}/usr/bin/clang-tblgen) >> 57 TBLGEN=3D ${TOOLSDIR}/usr/bin/tblgen >> 58 CLANG_TBLGEN=3D ${TOOLSDIR}/usr/bin/clang-tblgen >> 59 .endif >> 60 TBLGEN?=3D tblgen >> 61 CLANG_TBLGEN?=3D clang-tblgen >>=20 >> This kind of complexity matched something that I simplified at $work due t= o build races=E2=80=A6 >=20 > This stuff was added by sjg as part of his meta-mode commit frenzy in > r284345, but I never really agreed to it, nor do I understand what its > function is. It was just splattered all over the tree. >=20 > Can we just remove it for now, and put it back when it works, and is > actually used for something? :-) It is used only for meta mode. >=20 > -Dimitry >=20