Date: Thu, 30 Mar 2006 18:57:04 +0000 (UTC) From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/netipsec xform.h xform_ipip.c Message-ID: <200603301857.k2UIv46o066136@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
bz 2006-03-30 18:57:04 UTC
FreeBSD src repository
Modified files:
sys/netipsec xform.h xform_ipip.c
Log:
Fix more stack corruptions on amd64.
Vararg functions have a different calling convention than regular
functions on amd64. Casting a varag function to a regular one to
match the function pointer declaration will hide the varargs from
the caller and we will end up with an incorrectly setup stack.
Entirely remove the varargs from these functions and change the
functions to match the declaration of the function pointers.
Remove the now unnecessary casts.
Also change static struct ipprotosw[] to two independent
protosw/ip6protosw definitions to remove an unnecessary cast.
PR: amd64/95008
Submitted and tested by: Mats Palmgren
Reviewed by: rwatson
MFC after: 3 days
Revision Changes Path
1.3 +1 -1 src/sys/netipsec/xform.h
1.12 +10 -18 src/sys/netipsec/xform_ipip.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200603301857.k2UIv46o066136>