Date: Tue, 2 Oct 2001 13:38:20 -0400 From: Garance A Drosihn <drosih@rpi.edu> To: John Baldwin <jhb@FreeBSD.ORG>, Peter Wemm <peter@wemm.org> Cc: arch@FreeBSD.ORG, Warner Losh <imp@harmony.village.org>, Julian Elischer <julian@elischer.org> Subject: Re: Style Wars Message-ID: <p05101003b7dfaa0a1270@[128.113.24.47]> In-Reply-To: <XFMail.010928165401.jhb@FreeBSD.org> References: <XFMail.010928165401.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
At 4:54 PM -0700 9/28/01, John Baldwin wrote: >I'm think 1b) is the one most people have favored so far and it is >rather close to our existing style, so it's not that big of a change. >Does anyone object to 1b)? It basically results in the following >changes: use 2 tab spaces instead of 1 for type names, put the entire >type name before the tab(s), and if the type is too long, just use >a space. > >> 1b) >> >> struct foo { >> int f_type; >> struct mtx f_lock; >> const char *f_name; >> volatile int f_int; > > u_int64_t f_64; >> const volatile char f_cv; >> TAILQ_ENTRY(foo) f_link; > > }; This is the guideline that I prefer the most. It probably should include an example of a function-pointer. u_int64_t f_64; void (*fun_ptr)(int, char *[]); (which, I assume, would show that you would be lining up the name of the function pointer with the other variable names, so the argument list continues on to the right). -- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p05101003b7dfaa0a1270>