Date: Mon, 23 Feb 2004 07:40:16 -0800 (PST) From: John Baldwin <john@baldwin.cx> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/63171: USB keyboard rollover error [ukbd.c patch] Message-ID: <200402231540.i1NFeGW9000534@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/63171; it has been noted by GNATS. From: John Baldwin <john@baldwin.cx> To: freebsd-gnats-submit@FreeBSD.org, B.Candler@pobox.com Cc: Subject: Re: kern/63171: USB keyboard rollover error [ukbd.c patch] Date: Mon, 23 Feb 2004 10:34:08 -0500 The pointer fix does not seem correct. usbd_set_polling() does take a usbd_device_handle, not an interface pointer, so the existing code is correct on -current at least. Note that on 4.x, the poll method in ukbd.c does not use usbd_device_handle's but does pass the iface pointer in. This is due to the usbd code being different in current and stable. I have committed the ukbd rollover fix however. -- John Baldwin <john@baldwin.cx> <>< http://www.baldwin.cx/~john/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200402231540.i1NFeGW9000534>