From owner-freebsd-audit  Sun Jul 15  9:14:15 2001
Delivered-To: freebsd-audit@freebsd.org
Received: from iatl0x01.coxmail.com (iatl1x01.coxmail.com [206.157.231.23])
	by hub.freebsd.org (Postfix) with ESMTP id 1E19037B401
	for <audit@freebsd.org>; Sun, 15 Jul 2001 09:14:11 -0700 (PDT)
	(envelope-from mheffner@novacoxmail.com)
Received: from enterprise.muriel.penguinpowered.com ([208.138.198.178])
          by iatl0x01.coxmail.com
          (InterMail vK.4.03.02.00 201-232-124 license 85f4f10023be2bd3bce00b3a38363ea2)
          with ESMTP
          id <20010715161409.DAIE2144.iatl0x01@enterprise.muriel.penguinpowered.com>;
          Sun, 15 Jul 2001 12:14:09 -0400
Message-ID: <XFMail.20010715121233.mheffner@novacoxmail.com>
X-Mailer: XFMail 1.5.0 on FreeBSD
X-Priority: 3 (Normal)
MIME-Version: 1.0
Content-Type: multipart/signed;
 boundary="_=XFMail.1.5.0.FreeBSD:20010715121233:57103=_";
 micalg=pgp-md5; protocol="application/pgp-signature"
In-Reply-To: <20010715113642.C42CC3E2F@bazooka.unixfreak.org>
Date: Sun, 15 Jul 2001 12:12:33 -0400 (EDT)
Reply-To: Mike Heffner <mheffner@vt.edu>
From: Mike Heffner <mheffner@novacoxmail.com>
To: Dima Dorfman <dima@unixfreak.org>
Subject: RE: queue(3) patch for config(8)
Cc: audit@freebsd.org
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

This message is in MIME format
--_=XFMail.1.5.0.FreeBSD:20010715121233:57103=_
Content-Type: text/plain; charset=us-ascii


On 15-Jul-2001 Dima Dorfman wrote:
| Attached is a patch which converts config(8) to use the queue(3) API.
| Please review.

I only did a quick glance at it, but it looks alright.

| 
| Index: mkheaders.c
| ===================================================================
| RCS file: /stl/src/FreeBSD/src/usr.sbin/config/mkheaders.c,v
| retrieving revision 1.22
| diff -u -r1.22 mkheaders.c
| --- mkheaders.c       2001/01/31 11:18:49     1.22
| +++ mkheaders.c       2001/07/15 11:35:25

...

| @@ -97,7 +98,8 @@
|        * and "hicount" will be the highest unit declared.  do_header()
|        * must use this higher of these values.
|        */
| -     for (hicount = count = 0, dp = dtab; dp != 0; dp = dp->d_next) {
| +     hicount = count = 0;
| +     TAILQ_FOREACH(dp, &dtab_head, d_list) {
|               if (eq(dp->d_name, dev)) {
|                       count =
|                           dp->d_count != UNKNOWN ? dp->d_count : 1;


`hicount' can probably be axed altogether, it appears to have lost its use in
r1.16.


Mike

-- 
  Mike Heffner         <mheffner@[acm.]vt.edu>
  Fredericksburg, VA       <mikeh@FreeBSD.org>


--_=XFMail.1.5.0.FreeBSD:20010715121233:57103=_
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (FreeBSD)
Comment: For info see http://www.gnupg.org

iD8DBQE7UcDxFokZQs3sv5kRAm5PAJ9F2/GjiNsWIhGoBbc8dNVcujIAPACghX/u
0GHkLHSkuKzqQTpR76BhGic=
=iL/U
-----END PGP SIGNATURE-----

--_=XFMail.1.5.0.FreeBSD:20010715121233:57103=_--
End of MIME message

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message