Date: Tue, 17 Nov 2009 09:19:36 GMT From: Andrius Morkunas <hinokind@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/140635: [patch] Misleading error message with FORCE_MAKE_JOBS Message-ID: <200911170919.nAH9Jawg008559@www.freebsd.org> Resent-Message-ID: <200911170920.nAH9KCKv096709@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 140635
>Category: ports
>Synopsis: [patch] Misleading error message with FORCE_MAKE_JOBS
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Nov 17 09:20:12 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Andrius Morkunas
>Release: 8-RC1
>Organization:
>Environment:
>Description:
When FORCE_MAKE_JOBS is defined, if port build breaks, a message is shown:
"You have chosen to use multiple make jobs (parallelization) for all
ports. This port was not tested for this setting. Please remove
FORCE_MAKE_JOBS and retry the build before reporting the failure to
the maintainer."
The part "This port was not tested for this setting" implies that
the port was indeed _not_ tested with MAKE_JOBS_SAFE, which is not true
for ports that have MAKE_JOBS_SAFE defined, since the ports _were_ tested
and built with it, and failed build is likely not related to multiple
jobs.
>How-To-Repeat:
>Fix:
Only show the message if MAKE_JOBS_SAFE is not defined.
Patch attached.
Patch attached with submission follows:
--- Mk/bsd.port.mk.orig 2009-09-21 22:13:51.000000000 +0300
+++ Mk/bsd.port.mk 2009-11-17 10:31:30.538417706 +0200
@@ -2213,7 +2213,7 @@
.if defined(MAKE_JOBS_SAFE) || defined(FORCE_MAKE_JOBS)
MAKE_JOBS_NUMBER?= `${SYSCTL} -n kern.smp.cpus`
_MAKE_JOBS= -j${MAKE_JOBS_NUMBER}
-.if defined(FORCE_MAKE_JOBS)
+.if defined(FORCE_MAKE_JOBS) && !defined(MAKE_JOBS_SAFE)
BUILD_FAIL_MESSAGE+= "You have chosen to use multiple make jobs (parallelization) for all ports. This port was not tested for this setting. Please remove FORCE_MAKE_JOBS and retry the build before reporting the failure to the maintainer."
.endif
.endif
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200911170919.nAH9Jawg008559>