Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 7 Oct 2011 13:52:54 -0700
From:      YongHyeon PYUN <pyunyh@gmail.com>
To:        Sean Bruno <seanbru@yahoo-inc.com>
Cc:        "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>, David Christensen <davidch@broadcom.com>, "davidch@freebsd.org" <davidch@freebsd.org>, Pyun YongHyeon <yongari@freebsd.org>
Subject:   Re: bce(4) with IPMI
Message-ID:  <20111007205254.GC11808@michelle.cdnetworks.com>
In-Reply-To: <1318018310.27029.10.camel@hitfishpass-lx.corp.yahoo.com>
References:  <1317315666.2777.8.camel@hitfishpass-lx.corp.yahoo.com> <1317323418.2777.14.camel@hitfishpass-lx.corp.yahoo.com> <1317343996.2777.33.camel@hitfishpass-lx.corp.yahoo.com> <1317346748.2777.36.camel@hitfishpass-lx.corp.yahoo.com> <5D267A3F22FD854F8F48B3D2B523819385F35B4738@IRVEXCHCCR01.corp.ad.broadcom.com> <1317683178.15510.25.camel@hitfishpass-lx.corp.yahoo.com> <20111007191154.GB11808@michelle.cdnetworks.com> <1318018310.27029.10.camel@hitfishpass-lx.corp.yahoo.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--0OAP2g/MAC+5xKAE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Oct 07, 2011 at 01:11:50PM -0700, Sean Bruno wrote:
> On Fri, 2011-10-07 at 12:11 -0700, YongHyeon PYUN wrote:
> > > What's even more strange is that our freebsd6 instances don't have
> > this
> > > problem.  
> > > 
> > 
> > Can't explain either but probably stable/6 bce(4) may have used old
> > firmware. 
> 
> Ok, I can once again reach the IPMI controller if I remove this:
> 
> http://svnweb.freebsd.org/base/head/sys/dev/bce/if_bce.c?r1=210263&r2=210262&pathrev=210263
> 
> Since the driver has control over the interface, not "upping" the
> interface media causes the IPMI controller to not be able to access the
> network.  Ugh.  
> 

Hmm, it seems the firmware relies on driver to establish a link
such that blindly disabling PHY access in DOWN state seem to make
firmware believe that there is a no established link.
Could you try attached patch?

> Sean
> 

--0OAP2g/MAC+5xKAE
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="bce.mfm.diff"

Index: sys/dev/bce/if_bce.c
===================================================================
--- sys/dev/bce/if_bce.c	(revision 226114)
+++ sys/dev/bce/if_bce.c	(working copy)
@@ -6180,7 +6180,8 @@
 
 	BCE_LOCK(sc);
 
-	if ((ifp->if_flags & IFF_UP) == 0) {
+	if ((ifp->if_flags & IFF_UP) == 0 &&
+	    (sc->bce_flags & BCE_MFW_ENABLE_FLAG) == 0) {
 		BCE_UNLOCK(sc);
 		return;
 	}

--0OAP2g/MAC+5xKAE--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111007205254.GC11808>