From owner-freebsd-ports@FreeBSD.ORG Wed Feb 19 13:27:51 2014 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 08359545 for ; Wed, 19 Feb 2014 13:27:51 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id D9FE916BB for ; Wed, 19 Feb 2014 13:27:50 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id s1JDRo8H033395 for ; Wed, 19 Feb 2014 13:27:50 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s1JDRniq033392 for ports@freebsd.org; Wed, 19 Feb 2014 13:27:49 GMT (envelope-from bdrewery) Received: (qmail 40308 invoked from network); 19 Feb 2014 07:27:48 -0600 Received: from unknown (HELO ?10.10.0.24?) (freebsd@shatow.net@10.10.0.24) by sweb.xzibition.com with ESMTPA; 19 Feb 2014 07:27:48 -0600 Message-ID: <5304B151.1040907@FreeBSD.org> Date: Wed, 19 Feb 2014 07:27:45 -0600 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Andrew Hotlab Subject: Re: [patch] sysutils/beadm References: In-Reply-To: X-Enigmail-Version: 1.6 OpenPGP: id=6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cTt7lW6j38LJDxBkjQ1DHUNn7eeStXfT1" Cc: "ports@freebsd.org" , vermaden X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Feb 2014 13:27:51 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cTt7lW6j38LJDxBkjQ1DHUNn7eeStXfT1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2/13/2014 4:19 PM, Andrew Hotlab wrote: > First of all, thank you very much for the good work with this port. I'm= sure it's changing the life of a lot FreeBSD system administrators! >=20 > In my setup I have the following layout (several datasets for /usr, /va= r, etc.): >=20 > NAME USED AVAIL REFER MOUNTPOINT > sys 1.55G 18.0G 31K none > sys/ROOT 532M 18.0G 31K none > sys/ROOT/default 114K 18.0G 250M / > sys/ROOT/default/tmp 22K 18.0G 38K /tmp > sys/ROOT/default/usr 1K 18.0G 245M /usr > sys/ROOT/default/var 48.5K 18.0G 36.4M /var > sys/swap 1.03G 19.0G 16K - >=20 > At this moment the utility does not seems to be able to manage this sch= eme, since it sets the mountpoint property as "legacy" for all datasets u= nder the root, thus preventing to automatically mount any subdirectory at= boot. > I've tested this simple solution (to let do the job to the canmount pro= perty), and it seems to solve the problem without affecting the behavior = when all system folders are located under a single root dataset (please s= ee the patch below). I'd be glad if you'll include it in the next port re= vision. >=20 > I'm at your disposal for any further detail. >=20 > Best regards. >=20 > Andrew >=20 >=20 > --- ./beadm 2014-01-11 17:08:31.112384992 +0100 > +++ /usr/local/sbin/beadm 2014-01-11 17:06:38.620706860 +0100 > @@ -505,7 +505,7 @@ > if [ ${MOUNT} -eq 0 ] > then > zfs umount ${POOL}/${BEDS}/${2} > - zfs set mountpoint=3Dlegacy ${POOL}/${BEDS}/${2} > + zfs set mountpoint=3D/ ${POOL}/${BEDS}/${2} > fi > fi > if ! zpool set bootfs=3D${POOL}/${BEDS}/${2} ${POOL} 1> /dev/null 2> /d= ev/null > @@ -518,6 +518,7 @@ > ZFS_LIST=3D$( zfs list -H -o name -r ${POOL}/${BEDS} ) > # disable automatic mount on all inactive boot environments > echo "${ZFS_LIST}" \ > + | grep -v "^${POOL}/${BEDS}$" \ > | grep -v "^${POOL}/${BEDS}/${2}$" \ > | grep -v "^${POOL}/${BEDS}/${2}/" \ > | while read NAME =20 >=20 ACK on this. CC'ing upstream maintainer too. I run the same setup but I specifically set /usr /var and /tmp mntpoints to /usr,/var/,/tmp to avoid this issue. I am not sure if mntpoint=3D/ is proper. I recall there being an issue with it. I would much prefer your patch though if it is safe. Does beadm mount still work with this to mount a new BE into /tmp? Ie, beadm create newbe beadm mount newbe Does it go and remount / or only touch /tmp? How about activating? Does it blow away / right away or wait until reboot= ? --=20 Regards, Bryan Drewery --cTt7lW6j38LJDxBkjQ1DHUNn7eeStXfT1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJTBLFRAAoJEDXXcbtuRpfPZRsIAN+ZgfjDilBoqWnlLK278RUF EMFAQkx/ssEvtEr6ncwK0USncQJsPbzCrWIn6Ae0i2UxGVgi3O6hTEHaqsgOnJHi 1tqyhOyHV00hxFYVodURJM0Tu3drI2Gmo9bJ+k0IZHldyi7QaIH8HTZ1qYaBYNJK jYeEL+mq28mtPpZgfKaZbyf1lKs3jIQ/ZwPGM7fuuxKhzyMS+ifk9CRn9KJsEry0 DrI4Uc4e7nJUcpQB5th+t3YE6UL7MnpyrpnZ6+p127t4pFG4BII24SZRa9ZNQH9v ctToGxkF2mVqorpGlzeNWqBwxm2+uJlQ3804pJGbXdPcgLhYFAbeY02ADTH3BKc= =TQls -----END PGP SIGNATURE----- --cTt7lW6j38LJDxBkjQ1DHUNn7eeStXfT1--