Date: Mon, 6 Aug 2018 09:26:50 +0300 From: Ruslan Makhmatkhanov <rm@FreeBSD.org> To: Yuri <yuri@rawbw.com>, Ruslan Makhmatkhanov <rm@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r476012 - head/www/py-notebook Message-ID: <201be88c-f1dd-d127-7cdb-560eb050b279@FreeBSD.org> In-Reply-To: <aeb31315-3547-237d-ab2d-96935058e076@rawbw.com> References: <201807311838.w6VIcdFc056927@repo.freebsd.org> <aeb31315-3547-237d-ab2d-96935058e076@rawbw.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Yuri wrote on 8/6/18 1:23 AM:
> On 7/31/18 11:38 AM, Ruslan Makhmatkhanov wrote:
>> ==============================================================================
>>
>> --- head/www/py-notebook/Makefile Tue Jul 31 17:47:53 2018
>> (r476011)
>> +++ head/www/py-notebook/Makefile Tue Jul 31 18:38:39 2018
>> (r476012)
>> @@ -25,16 +25,11 @@ RUN_DEPENDS=
>> ${PYTHON_PKGNAMEPREFIX}Jinja2>=0:devel/py
>>
>> ${PYTHON_PKGNAMEPREFIX}terminado>=0.8.1:net/py-terminado@${PY_FLAVOR} \
>> ${PYTHON_PKGNAMEPREFIX}tornado>=4:www/py-tornado@${PY_FLAVOR} \
>>
>> ${PYTHON_PKGNAMEPREFIX}traitlets>=4.2.1:devel/py-traitlets@${PY_FLAVOR} \
>> -
>> ${PYTHON_PKGNAMEPREFIX}prometheus-client>0:net-mgmt/py-prometheus-client@${PY_FLAVOR}
>>
>> +
>> ${PYTHON_PKGNAMEPREFIX}prometheus-client>0:net-mgmt/py-prometheus-client@${PY_FLAVOR}
>> \
>> + ${PY_IPADDRESS}
>
>
> Hi Ruslan,
>
>
> You need to bump ports when you change runtime dependencies.
Hi Yuri,
Until that change py-notebook has dependency upon py-ipaddress like this:
-.if ${PYTHON_REL} < 3000
-RUN_DEPENDS+=
${PYTHON_PKGNAMEPREFIX}ipaddress>0:net/py-ipaddress@${PY_FLAVOR}
-.endif
And in r476012 I changed it to
RUN_DEPENDS+= ${PY_IPADDRESS}
that, if you check Uses/python.mk, translates to
.if ${PYTHON_REL} < 3300
PY_IPADDRESS=
${PYTHON_PKGNAMEPREFIX}ipaddress>0:net/py-ipaddress@${PY_FLAVOR}
.else
PY_IPADDRESS=
.endif
And I explicitly stated in commit message that nothing is actually
changed and no PORTREVISION bump is required. In what way this package
was broken after r476012?
>
> See here:
> https://docs.freebsd.org/doc/4.5-RELEASE/usr/share/doc/en/books/porters-handbook/x387.html
>
>
> This package is currently broken with missing dependencies.
>
>
> Regards,
>
> Yuri
--
Regards,
Ruslan
T.O.S. Of Reality
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201be88c-f1dd-d127-7cdb-560eb050b279>