From owner-svn-ports-all@freebsd.org Mon Aug 6 06:29:49 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6DD11106D56C; Mon, 6 Aug 2018 06:29:49 +0000 (UTC) (envelope-from rm@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 199B38AACC; Mon, 6 Aug 2018 06:29:49 +0000 (UTC) (envelope-from rm@FreeBSD.org) Received: from [127.0.0.1] (unknown [127.0.1.132]) by freefall.freebsd.org (Postfix) with ESMTP id 172B61CFD6; Mon, 6 Aug 2018 06:29:47 +0000 (UTC) (envelope-from rm@FreeBSD.org) Subject: Re: svn commit: r476012 - head/www/py-notebook To: Yuri , Ruslan Makhmatkhanov , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201807311838.w6VIcdFc056927@repo.freebsd.org> From: Ruslan Makhmatkhanov Message-ID: <201be88c-f1dd-d127-7cdb-560eb050b279@FreeBSD.org> Date: Mon, 6 Aug 2018 09:26:50 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Aug 2018 06:29:49 -0000 Yuri wrote on 8/6/18 1:23 AM: > On 7/31/18 11:38 AM, Ruslan Makhmatkhanov wrote: >> ============================================================================== >> >> --- head/www/py-notebook/Makefile    Tue Jul 31 17:47:53 2018 >> (r476011) >> +++ head/www/py-notebook/Makefile    Tue Jul 31 18:38:39 2018 >> (r476012) >> @@ -25,16 +25,11 @@ RUN_DEPENDS= >> ${PYTHON_PKGNAMEPREFIX}Jinja2>=0:devel/py >> >> ${PYTHON_PKGNAMEPREFIX}terminado>=0.8.1:net/py-terminado@${PY_FLAVOR} \ >>           ${PYTHON_PKGNAMEPREFIX}tornado>=4:www/py-tornado@${PY_FLAVOR} \ >> >> ${PYTHON_PKGNAMEPREFIX}traitlets>=4.2.1:devel/py-traitlets@${PY_FLAVOR} \ >> - >> ${PYTHON_PKGNAMEPREFIX}prometheus-client>0:net-mgmt/py-prometheus-client@${PY_FLAVOR} >> >> + >> ${PYTHON_PKGNAMEPREFIX}prometheus-client>0:net-mgmt/py-prometheus-client@${PY_FLAVOR} >> \ >> +        ${PY_IPADDRESS} > > > Hi Ruslan, > > > You need to bump ports when you change runtime dependencies. Hi Yuri, Until that change py-notebook has dependency upon py-ipaddress like this: -.if ${PYTHON_REL} < 3000 -RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}ipaddress>0:net/py-ipaddress@${PY_FLAVOR} -.endif And in r476012 I changed it to RUN_DEPENDS+= ${PY_IPADDRESS} that, if you check Uses/python.mk, translates to .if ${PYTHON_REL} < 3300 PY_IPADDRESS= ${PYTHON_PKGNAMEPREFIX}ipaddress>0:net/py-ipaddress@${PY_FLAVOR} .else PY_IPADDRESS= .endif And I explicitly stated in commit message that nothing is actually changed and no PORTREVISION bump is required. In what way this package was broken after r476012? > > See here: > https://docs.freebsd.org/doc/4.5-RELEASE/usr/share/doc/en/books/porters-handbook/x387.html > > > This package is currently broken with missing dependencies. > > > Regards, > > Yuri -- Regards, Ruslan T.O.S. Of Reality