From owner-trustedbsd-cvs@FreeBSD.ORG  Sat Feb 25 06:11:57 2006
Return-Path: <owner-trustedbsd-cvs@FreeBSD.ORG>
X-Original-To: trustedbsd-cvs@freebsd.org
Delivered-To: trustedbsd-cvs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EDCBC16A424
	for <trustedbsd-cvs@freebsd.org>; Sat, 25 Feb 2006 06:11:57 +0000 (GMT)
	(envelope-from owner-perforce@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4907543D46
	for <trustedbsd-cvs@freebsd.org>; Sat, 25 Feb 2006 06:11:57 +0000 (GMT)
	(envelope-from owner-perforce@freebsd.org)
Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119])
	by cyrus.watson.org (Postfix) with ESMTP id 435F946BF4
	for <trustedbsd-cvs@trustedbsd.org>;
	Sat, 25 Feb 2006 01:11:39 -0500 (EST)
Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18])
	by mx2.freebsd.org (Postfix) with ESMTP id 887AA57EAF;
	Sat, 25 Feb 2006 06:11:55 +0000 (GMT)
	(envelope-from owner-perforce@freebsd.org)
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 8265B16A422; Sat, 25 Feb 2006 06:11:55 +0000 (GMT)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 232E216A423
	for <perforce@freebsd.org>; Sat, 25 Feb 2006 06:11:55 +0000 (GMT)
	(envelope-from csjp@FreeBSD.org)
Received: from ems01.seccuris.com (ems01.seccuris.com [204.112.0.35])
	by mx1.FreeBSD.org (Postfix) with SMTP id 3CC7043D46
	for <perforce@freebsd.org>; Sat, 25 Feb 2006 06:11:54 +0000 (GMT)
	(envelope-from csjp@FreeBSD.org)
Received: (qmail 4907 invoked by uid 0); 25 Feb 2006 06:18:53 -0000
Received: from unknown (HELO ?192.168.1.100?) (unknown)
	by unknown with SMTP; 25 Feb 2006 06:18:53 -0000
Message-ID: <43FFF528.7070100@FreeBSD.org>
Date: Sat, 25 Feb 2006 00:11:52 -0600
From: "Christian S.J. Peron" <csjp@FreeBSD.org>
User-Agent: Mozilla Thunderbird 1.0.7 (Macintosh/20050923)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Robert Watson <rwatson@FreeBSD.org>
References: <200602250012.k1P0CgNJ041723@repoman.freebsd.org>
In-Reply-To: <200602250012.k1P0CgNJ041723@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 92365 for review
X-BeenThere: trustedbsd-cvs@FreeBSD.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: TrustedBSD CVS and Perforce commit message list
	<trustedbsd-cvs.FreeBSD.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/trustedbsd-cvs>, 
	<mailto:trustedbsd-cvs-request@FreeBSD.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/trustedbsd-cvs>
List-Post: <mailto:trustedbsd-cvs@FreeBSD.org>
List-Help: <mailto:trustedbsd-cvs-request@FreeBSD.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/trustedbsd-cvs>,
	<mailto:trustedbsd-cvs-request@FreeBSD.org?subject=subscribe>
X-List-Received-Date: Sat, 25 Feb 2006 06:11:58 -0000

Robert Watson wrote:

>http://perforce.freebsd.org/chv.cgi?CH=92365
>
>Change 92365 by rwatson@rwatson_peppercorn on 2006/02/25 00:12:28
>
>	On systems without LOG_SECURITY defined, use LOG_AUTH.
>	
>	Reported by:	Martin Fong <martin dot fong at sri dot com>
>
>Affected files ...
>
>.. //depot/projects/trustedbsd/openbsm/bin/auditd/auditd.c#13 edit
>
>Differences ...
>
>==== //depot/projects/trustedbsd/openbsm/bin/auditd/auditd.c#13 (text+ko) ====
>
>@@ -30,7 +30,7 @@
>  *
>  * @APPLE_BSD_LICENSE_HEADER_END@
>  *
>- * $P4: //depot/projects/trustedbsd/openbsm/bin/auditd/auditd.c#12 $
>+ * $P4: //depot/projects/trustedbsd/openbsm/bin/auditd/auditd.c#13 $
>  */
> 
> #include <sys/types.h>
>@@ -795,7 +795,11 @@
> 		}
> 	}
> 
>+#ifdef LOG_SECURITY
> 	openlog("auditd", LOG_CONS | LOG_PID, LOG_SECURITY);
>+#else
>+	openlog("auditd", LOG_CONS | LOG_PID, LOG_AUTH);
>+#endif
> 	syslog(LOG_INFO, "starting...\n");
> 
> 	if (debug == 0 && daemon(0, 0) == -1) {
>
>
>  
>
In userspace, we are using LOG_AUTH | LOG_ERR to report audit failures, 
at least for login(1) and su(1).
Might be a good idea to be consistent, anyway.

-- 
Christian S.J. Peron
csjp@FreeBSD.ORG
FreeBSD Committer
FreeBSD Security Team