From owner-svn-src-head@freebsd.org Tue Aug 16 13:37:12 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4D2CFBBB955; Tue, 16 Aug 2016 13:37:12 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 102D21D24; Tue, 16 Aug 2016 13:37:12 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from slw by zxy.spb.ru with local (Exim 4.86 (FreeBSD)) (envelope-from ) id 1bZeYH-000GNm-Gn; Tue, 16 Aug 2016 16:37:09 +0300 Date: Tue, 16 Aug 2016 16:37:09 +0300 From: Slawa Olhovchenkov To: Randall Stewart Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r304218 - head/sys/netinet Message-ID: <20160816133709.GL22212@zxy.spb.ru> References: <201608161240.u7GCeuWS082118@repo.freebsd.org> <20160816131805.GK22212@zxy.spb.ru> <16561701-B1C6-4BE3-B9BA-3535F564620F@netflix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <16561701-B1C6-4BE3-B9BA-3535F564620F@netflix.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2016 13:37:12 -0000 On Tue, Aug 16, 2016 at 06:21:14AM -0700, Randall Stewart via svn-src-all wrote: > > In theory it *could* be MFC’d to stable-10 and 11 but I am not sure we want to do that. I am > told by Drew that it does improve performance since in stable-10 you are getting the INFO_WLOCK() > but I am not sure if folks want it MFC’d… > > One thing that this code leads us towards is we *in theory* could move the lock acquisition to the > timer code itself (I think).. we would have to make sure that the callout functions did do the > unlock since thats part of the lock-dance with reference… but its theoretically possible :-) What reason to not MFC? I mean MFCed all don't break API/ABI.