From owner-svn-src-head@FreeBSD.ORG Tue Jun 7 20:20:17 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1C3F3106566B; Tue, 7 Jun 2011 20:20:17 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id E61228FC13; Tue, 7 Jun 2011 20:20:16 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 8312546B46; Tue, 7 Jun 2011 16:20:16 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 0560D8A01F; Tue, 7 Jun 2011 16:20:16 -0400 (EDT) From: John Baldwin To: "Jung-uk Kim" Date: Tue, 7 Jun 2011 16:05:30 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; ) References: <201106062303.p56N3cjs053024@svn.freebsd.org> <201106071402.11620.jhb@freebsd.org> <201106071508.31068.jkim@FreeBSD.org> In-Reply-To: <201106071508.31068.jkim@FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201106071605.30586.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Tue, 07 Jun 2011 16:20:16 -0400 (EDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r222795 - head/sys/dev/atkbdc X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2011 20:20:17 -0000 On Tuesday, June 07, 2011 3:08:29 pm Jung-uk Kim wrote: > On Tuesday 07 June 2011 02:02 pm, John Baldwin wrote: > > On Tuesday, June 07, 2011 11:39:26 am Jung-uk Kim wrote: > > > On Tuesday 07 June 2011 09:52 am, John Baldwin wrote: > > > The whole point of this commit is to blacklist *recent* BIOS (or > > > CSM) from probing keyboard typematic information, more > > > specifically, recent Intel chipset platforms. They don't support > > > many INT 15h/16h functions but only cause trouble at best. OTOH, > > > I haven't seen such problems with AMD chipset systems and they > > > all seem to have traditional entry points at the interrupt vector > > > table, for example. > > > > Err, but you didn't blacklist recent BIOS. You blacklist _all_ > > BIOS that use entry points other than the ones from the UEFI spec, > > including BIOSes that don't claim to support UEFI and the BIOS from > > the two systems I quoted. > > Relax. The entry points were originally from IBM PC/AT and PS/2 > systems and UEFI CSM spec. was written to ensure backward > compatibility with the *real* BIOS. I am quite sure your BIOS > doesn't support keyboard typematic, i.e., it doesn't have sufficient > compatibility with the original IBM BIOS. If it does, I'll happily > revert the change. :-) Hmm, I had not expected such consistency among BIOS implementations given the number of vendors, etc. I would probably be fine with just removing this feature entirely though unless it is truly useful. -- John Baldwin