From owner-cvs-all@FreeBSD.ORG Mon Jun 6 18:37:14 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C8F9F16A41C; Mon, 6 Jun 2005 18:37:14 +0000 (GMT) (envelope-from sos@FreeBSD.org) Received: from spider.deepcore.dk (cpe.atm2-0-53484.0x50a6c9a6.abnxx9.customer.tele.dk [80.166.201.166]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3BD1643D1D; Mon, 6 Jun 2005 18:37:14 +0000 (GMT) (envelope-from sos@FreeBSD.org) Received: from [194.192.25.136] (mac.deepcore.dk [194.192.25.136]) by spider.deepcore.dk (8.13.3/8.13.3) with ESMTP id j56Ia5Ui069981; Mon, 6 Jun 2005 20:36:05 +0200 (CEST) (envelope-from sos@FreeBSD.org) In-Reply-To: <42A490F2.4010705@root.org> References: <20050606154917.7AEE716A42B@hub.freebsd.org> <42A490F2.4010705@root.org> Mime-Version: 1.0 (Apple Message framework v730) Content-Type: text/plain; charset=ISO-8859-1; delsp=yes; format=flowed Message-Id: <8F5450B3-BEB2-4FAC-A8C4-E64D626EA1C6@FreeBSD.org> Content-Transfer-Encoding: quoted-printable From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= Date: Mon, 6 Jun 2005 20:37:09 +0200 To: Nate Lawson X-Mailer: Apple Mail (2.730) X-mail-scanned: by DeepCore Virus & Spam killer v1.12 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ata ata-raid.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jun 2005 18:37:15 -0000 On 06/06/2005, at 20:07, Nate Lawson wrote: > S=F8ren Schmidt wrote: > >> sos 2005-06-06 15:49:09 UTC >> FreeBSD src repository >> Modified files: >> sys/dev/ata ata-raid.c Log: >> Apply the usual woodoo for 64bitness. >> Revision Changes Path >> 1.97 +2 -2 src/sys/dev/ata/ata-raid.c >> Index: src/sys/dev/ata/ata-raid.c >> diff -u src/sys/dev/ata/ata-raid.c:1.96 src/sys/dev/ata/ata-raid.c:=20= >> 1.97 >> --- src/sys/dev/ata/ata-raid.c:1.96 Mon Jun 6 13:35:23 2005 >> +++ src/sys/dev/ata/ata-raid.c Mon Jun 6 15:49:09 2005 >> @@ -3822,8 +3822,8 @@ >> printf("revision %.4s\n", meta->revision); >> printf("dummy_1 0x%08x\n", meta->dummy_1); >> printf("magic_0 0x%08x\n", meta->magic_0); >> - printf("magic_1 0x%016llx\n", meta->magic_1); >> - printf("magic_2 0x%016llx\n", meta->magic_2); >> + printf("magic_1 0x%016llx\n",(unsigned long long)=20 >> meta->magic_1); >> + printf("magic_2 0x%016llx\n",(unsigned long long)=20 >> meta->magic_2); >> printf("flags 0x%02x\n", meta->flags); >> printf("array_width %d\n", meta->array_width); >> printf("total_disks %d\n", meta->total_disks); >> > > I think %jx is preferred to a cast. I think I prefer the style of the rest of ATA. - S=F8ren