Date: Wed, 12 Mar 2014 14:20:00 GMT From: Tor Halvard Furulund <squat@squat.no> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/187105: [PATCH] net/miniupnpd fix incrrect redirect filter Message-ID: <201403121420.s2CEK0HW065260@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/187105; it has been noted by GNATS. From: Tor Halvard Furulund <squat@squat.no> To: bug-followup@freebsd.org Cc: HASHI Hiroaki <hashiz@meridiani.jp> Subject: Re: ports/187105: [PATCH] net/miniupnpd fix incrrect redirect filter Date: Wed, 12 Mar 2014 15:16:55 +0100 --=_b82f68c3e8a05ad98d4ff30259b5c386 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=UTF-8; format=flowed Thanks for sending this upstream. As maintainer I approve HASHI Hiroakis latest patch, I have also attached an alternative. I am not sure if HASHI Hiroakis creative usage of PORTREVISION is prefered? Makes it hard to bump PORTREVISION without changing the DISTNAME or something creative. My vote is more for changing PORTVERSION to 1.8.20140310 and remove the PORTREVISION- and DISTNAME-entries. That would break for an possible future 1.8.1-release (without PORTEPOCH), but the miniupnpd-project seems to use 1.8 (major.minor) via the in-between/devel-releases named 1.8.date (major.minor.date) to 1.9 (major.minor). A second alternative can be to set the version to 1.8.0.20140310 and use other variables to get DISTNAME and the other variables properly. -- Tor Halvard Furulund Maintainer of net/miniupnpd --=_b82f68c3e8a05ad98d4ff30259b5c386 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=miniupnpd-1.8.20140310.patch Content-Disposition: attachment; filename=miniupnpd-1.8.20140310.patch; size=962 ZGlmZiAtcnVOIC91c3IvcG9ydHMvbmV0L21pbml1cG5wZC9NYWtlZmlsZSBtaW5pdXBucGQvTWFr ZWZpbGUKLS0tIC91c3IvcG9ydHMvbmV0L21pbml1cG5wZC9NYWtlZmlsZQkyMDE0LTAxLTI2IDE1 OjI3OjEwLjAwMDAwMDAwMCArMDEwMAorKysgbWluaXVwbnBkL01ha2VmaWxlCTIwMTQtMDMtMTAg MTU6MjY6MjUuNTcyMzQ5OTYzICswMTAwCkBAIC0yLDggKzIsNyBAQAogIyAkRnJlZUJTRDogaGVh ZC9uZXQvbWluaXVwbnBkL01ha2VmaWxlIDM0MTE3OCAyMDE0LTAxLTI2IDE0OjI3OjEwWiBtYXJp bm8gJAogCiBQT1JUTkFNRT0JbWluaXVwbnBkCi1QT1JUVkVSU0lPTj0JMS44Ci1QT1JUUkVWSVNJ T049CTEKK1BPUlRWRVJTSU9OPQkxLjguMjAxNDAzMTAKIFBPUlRFUE9DSD0JMQogQ0FURUdPUklF Uz0JbmV0CiBNQVNURVJfU0lURVM9CWh0dHA6Ly9taW5pdXBucC50dXhmYW1pbHkub3JnL2ZpbGVz LyBcCmRpZmYgLXJ1TiAvdXNyL3BvcnRzL25ldC9taW5pdXBucGQvZGlzdGluZm8gbWluaXVwbnBk L2Rpc3RpbmZvCi0tLSAvdXNyL3BvcnRzL25ldC9taW5pdXBucGQvZGlzdGluZm8JMjAxNC0wMS0y MiAxNjozMDoxMy4wMDAwMDAwMDAgKzAxMDAKKysrIG1pbml1cG5wZC9kaXN0aW5mbwkyMDE0LTAz LTEwIDE1OjI4OjE1LjcxOTM0Mjk5MSArMDEwMApAQCAtMSwyICsxLDIgQEAKLVNIQTI1NiAobWlu aXVwbnBkLTEuOC50YXIuZ3opID0gZTQ1M2E5MjI1YTI4ODNlNzU5ZDA5ZTE1YzUxYmIwMjY1Yjhh MDE5ZDExMzI0MzQxMzFlNjkyOWZlZjAwNzZiYgotU0laRSAobWluaXVwbnBkLTEuOC50YXIuZ3op ID0gMTQ2Njc5CitTSEEyNTYgKG1pbml1cG5wZC0xLjguMjAxNDAzMTAudGFyLmd6KSA9IDczMzUz MGVlZTk3MGJmYzI5ZjkwYjBhNzkzNjEyZDJjNzIxZWI0ZjE5ZjljNTBmNmQ3Njc3YjZlMGQ1OWE3 MjYKK1NJWkUgKG1pbml1cG5wZC0xLjguMjAxNDAzMTAudGFyLmd6KSA9IDE3NjU4NQo= --=_b82f68c3e8a05ad98d4ff30259b5c386--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201403121420.s2CEK0HW065260>