From owner-svn-src-all@FreeBSD.ORG Tue Aug 31 02:07:13 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 960EF106564A; Tue, 31 Aug 2010 02:07:13 +0000 (UTC) (envelope-from nwhitehorn@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 857038FC13; Tue, 31 Aug 2010 02:07:13 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o7V27Dh1015004; Tue, 31 Aug 2010 02:07:13 GMT (envelope-from nwhitehorn@svn.freebsd.org) Received: (from nwhitehorn@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o7V27DjC015002; Tue, 31 Aug 2010 02:07:13 GMT (envelope-from nwhitehorn@svn.freebsd.org) Message-Id: <201008310207.o7V27DjC015002@svn.freebsd.org> From: Nathan Whitehorn Date: Tue, 31 Aug 2010 02:07:13 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r212044 - head/sys/powerpc/aim X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Aug 2010 02:07:13 -0000 Author: nwhitehorn Date: Tue Aug 31 02:07:13 2010 New Revision: 212044 URL: http://svn.freebsd.org/changeset/base/212044 Log: Missed one place the SLB lock should be held in r211967. Modified: head/sys/powerpc/aim/mmu_oea64.c Modified: head/sys/powerpc/aim/mmu_oea64.c ============================================================================== --- head/sys/powerpc/aim/mmu_oea64.c Tue Aug 31 01:16:45 2010 (r212043) +++ head/sys/powerpc/aim/mmu_oea64.c Tue Aug 31 02:07:13 2010 (r212044) @@ -2232,12 +2232,14 @@ moea64_qremove(mmu_t mmu, vm_offset_t va void moea64_release_vsid(uint64_t vsid) { - int idx, mask; + int idx, mask; - idx = vsid & (NVSIDS-1); - mask = 1 << (idx % VSID_NBPW); - idx /= VSID_NBPW; - moea64_vsid_bitmap[idx] &= ~mask; + mtx_lock(&moea64_slb_mutex); + idx = vsid & (NVSIDS-1); + mask = 1 << (idx % VSID_NBPW); + idx /= VSID_NBPW; + moea64_vsid_bitmap[idx] &= ~mask; + mtx_unlock(&moea64_slb_mutex); } @@ -2253,7 +2255,7 @@ moea64_release(mmu_t mmu, pmap_t pmap) slb_free_user_cache(pmap->pm_slb); #else if (pmap->pm_sr[0] == 0) - panic("moea64_release"); + panic("moea64_release: pm_sr[0] = 0"); moea64_release_vsid(pmap->pm_sr[0]); #endif