From owner-freebsd-current@FreeBSD.ORG Tue Oct 16 10:48:46 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6ABE516A418 for ; Tue, 16 Oct 2007 10:48:46 +0000 (UTC) (envelope-from avleeuwen@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.183]) by mx1.freebsd.org (Postfix) with ESMTP id 576AA13C4A5 for ; Tue, 16 Oct 2007 10:48:46 +0000 (UTC) (envelope-from avleeuwen@gmail.com) Received: by wa-out-1112.google.com with SMTP id k17so2374459waf for ; Tue, 16 Oct 2007 03:48:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:references; bh=yPTnAL0IH6h2A8KfgalDSk/vAM9ra2CiA0tKMqBiNRI=; b=KcolgvSJxUA8DfWn3Gd3qwku4Mv+wyxk3XAAPnUfRaTIaup0iBoX0T+S+ytmwoWaBUIpl01i0mSGzbSg57TzcifxeNkgPDJbF5idS/6sPD2p83Sozf6JpiAoKhrsbByoGbZJtCmydgdcd+WmvCMBnaa2bnnoFuum2Z3U1WgUYco= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:references; b=JVSP1Psk+emGtnOLSvsTwCgoGZRw+NnxXUIefEArSlATh1QcJMHY7HQC/UXNeGyTsk8ZdSrNe1c5bEVmtyyYVYst/0AH1/7U5ncoiSa1beVrE/ntTEmGY4IgLljQmxZxyiq18G9AiX6q+b+CBSODjCa9uHRFHjXRYFrLeNty9EE= Received: by 10.114.111.1 with SMTP id j1mr8226311wac.1192530059198; Tue, 16 Oct 2007 03:20:59 -0700 (PDT) Received: by 10.114.133.11 with HTTP; Tue, 16 Oct 2007 03:20:59 -0700 (PDT) Message-ID: Date: Tue, 16 Oct 2007 12:20:59 +0200 From: "Arjan van Leeuwen" To: "Eric Anderson" In-Reply-To: <471427BE.10500@freebsd.org> MIME-Version: 1.0 References: <1191175387.92510.6.camel@shumai.marcuscom.com> <200710131857.46963.pieter@degoeje.nl> <471170E1.2090205@freebsd.org> <200710140408.46121.pieter@degoeje.nl> <471427BE.10500@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Pieter de Goeje , freebsd-current@freebsd.org, Rolf Witt Subject: Re: panic: ffs_blkfree: freeing free block X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: avleeuwen@piwebs.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 10:48:46 -0000 2007/10/16, Eric Anderson : > > Pieter de Goeje wrote: > > On Sunday 14 October 2007, Eric Anderson wrote: > >> Pieter de Goeje wrote: > >>> On Saturday 13 October 2007, Rolf Witt wrote: > >>>> Backtrace from crash tonight (after portsnap cron): > >>> > >>> > >>>> # uname -a > >>>> FreeBSD peanuts.homenet.local 7.0-PRERELEASE FreeBSD 7.0-PRERELEASE > >>>> #121: Thu Oct 11 16:29:05 CEST 2007 > >>>> rowi@peanuts.homenet.local:/usr/obj/usr/src/sys/PEANUTS i386 > >>>> > >>>> Sources from Builddate. > >>>> > >>>> Rowi > >>> Eric sent me this patch: > >>> http://www.googlebit.com/freebsd/patches/ffs_softdep.c-patch > >>> which seems to be working great so far. I am still testing it, but I > >>> think it fixed the problem. > >>> To apply, cd /usr/src; patch < /path/to/patch and then rebuild the > >>> kernel. > >>> > >>> Cheers, > >>> Pieter de Goeje > >> It doesn't actually 'fix' the problem, but I think it helps identify > it. > >> I'm not 100% certain if this is the right fix our not, but so far > >> feedback has been good when running with this patch. > >> > >> Can somebody confirm that this patch is ok? > >> > >> Eric > > Can you elaborate on what this patch exactly does / what the problem is? > > > > Pieter > > > I think the problem is that blocks are being put in the worklist twice, > but I'm not certain why yet. The patch reduces the chance of this > happening by more often removing the block from the worklist instead of > leaving it on. I think actually the patch is hiding the real issue more > than anything, which is why I said it isn't fixing the problem, but > because of the reports I've seen, I think we're sniffing in the right > area. I'll be looking more into this soon, when I get another few > minutes of free time and my debugger.. I actually seem to be getting the panic more often with the patch (i.e. twice in just 30 minutes with the patch, about twice per day without the patch), while doing the same things as usual. The panic usually happens when I'm compiling or linking. Is that strange? Arjan