Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 6 Mar 2016 17:00:04 +0100
From:      Oliver Pinter <oliver.pinter@hardenedbsd.org>
To:        Dimitry Andric <dim@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org,  svn-src-head@freebsd.org
Subject:   Re: svn commit: r296428 - head/sys/boot/common
Message-ID:  <CAPQ4ffut5jLNp5X4cV_DCsPGfv4Fw%2BPVm0ANNftuj2PLFZrjtQ@mail.gmail.com>
In-Reply-To: <201603061557.u26FvhMi033982@repo.freebsd.org>
References:  <201603061557.u26FvhMi033982@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 3/6/16, Dimitry Andric <dim@freebsd.org> wrote:
> Author: dim
> Date: Sun Mar  6 15:57:43 2016
> New Revision: 296428
> URL: https://svnweb.freebsd.org/changeset/base/296428
>
> Log:
>   Since kernel modules can now contain sections of type SHT_AMD64_UNWIND,
>   the boot loader should not skip over these anymore while loading images.
>   Otherwise the kernel can still panic when it doesn't find the .eh_frame
>   section belonging to the .rela.eh_frame section.
>
>   Unfortunately this will require installing boot loaders from sys/boot
>   before attempting to boot with a new kernel.

Could you please add a note about this to UPDATING file?

>
>   Reviewed by:	kib
>   MFC after:	2 weeks
>   X-MFC-With:	r296419
>
> Modified:
>   head/sys/boot/common/load_elf_obj.c
>
> Modified: head/sys/boot/common/load_elf_obj.c
> ==============================================================================
> --- head/sys/boot/common/load_elf_obj.c	Sun Mar  6 14:37:49 2016	(r296427)
> +++ head/sys/boot/common/load_elf_obj.c	Sun Mar  6 15:57:43 2016	(r296428)
> @@ -221,6 +221,9 @@ __elfN(obj_loadimage)(struct preloaded_f
>  		switch (shdr[i].sh_type) {
>  		case SHT_PROGBITS:
>  		case SHT_NOBITS:
> +#if defined(__i386__) || defined(__amd64__)
> +		case SHT_AMD64_UNWIND:
> +#endif
>  			lastaddr = roundup(lastaddr, shdr[i].sh_addralign);
>  			shdr[i].sh_addr = (Elf_Addr)lastaddr;
>  			lastaddr += shdr[i].sh_size;
> _______________________________________________
> svn-src-head@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/svn-src-head
> To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org"
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPQ4ffut5jLNp5X4cV_DCsPGfv4Fw%2BPVm0ANNftuj2PLFZrjtQ>