Date: Mon, 22 Jan 2007 17:24:54 +0800 From: "Sepherosa Ziehau" <sepherosa@gmail.com> To: pyunyh@gmail.com Cc: freebsd-current@freebsd.org Subject: Re: Call for re(4) checksum offload testers. Message-ID: <ea7b9c170701220124k68cb30doc9dd982bcb300226@mail.gmail.com> In-Reply-To: <20070122073611.GC29223@cdnetworks.co.kr> References: <20070122073611.GC29223@cdnetworks.co.kr>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1/22/07, Pyun YongHyeon <pyunyh@gmail.com> wrote: > Hi, > > It seems that some revisions of re(4) hardwares(PCIe variants?) still > have Tx checksum offload issues. One user reported the issue said > the attached patch fixed the issue on his box. -#define RL_MIN_FRAMELEN 60 +/* + * re(4) hardware IPv4 Tx checksum offload could be mangled with 28 bytes + * or less IP packets. + */ +#define RL_TXCSUM_MINLEN 28 +#define RL_MIN_FRAMELEN (ETHER_HDR_LEN + RL_TXCSUM_MINLEN) Does you patch mean a buggy PCIe re(4) will trash small packets padded to 60bytes but will not trash small packets padded to 42bytes? If "yes" is the answer, then why normal packets whose size is 60bytes will not be trashed by a buggy PCIe re(4)? IMHO, "fixing buggy PCIe re(4) txcsum" is not NetBSD's original intention to narrow down the size of packets that will trigger the re(4) txcsum bug. Best Regards, sephe -- Live Free or Die
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ea7b9c170701220124k68cb30doc9dd982bcb300226>