From owner-freebsd-apache@FreeBSD.ORG Tue Sep 9 22:43:43 2014 Return-Path: Delivered-To: apache@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7DA88B3C; Tue, 9 Sep 2014 22:43:43 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1697A32A; Tue, 9 Sep 2014 22:43:42 +0000 (UTC) Received: from [192.168.0.101] ([87.139.233.65]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MaZWz-1XgghZ0Nzd-00K4vS; Wed, 10 Sep 2014 00:43:40 +0200 Message-ID: <540F829C.10301@gmx.de> Date: Wed, 10 Sep 2014 00:43:40 +0200 From: olli hauer User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: apache@freebsd.org Subject: Re: apache 2.2 ports References: <8DF8037F-F9EC-488D-86C4-0923789C174C@adamw.org> <8c7c200293f6d84e756d6eec4a1edcc2@mail.feld.me> <1078D71E80C9283D7F23513F@ogg.in.absolight.net> <540F7CFB.4050304@gmx.de> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:C6fAhjEZiHE48B6SHMPknZQrjZqo0sWZmr2orW8L8XLglIihbEY LwNROO/ShaJvy1LwC2WAWgeP5AI/axjLval28dmtPgVQFtW6Jv969nm+UAVkVcxjsokAxDe oJg7+kOMlQjwwXKONI30925MExaf1o6gNVE5eKgUgA6mokFCHQfKLzS7NKoXS9fohcyQpEJ yi+/YENTC+nhf1RaBaH0w== X-UI-Out-Filterresults: notjunk:1; Cc: Mathieu Arnold , Baptiste Daroussin , Adam Weinberger X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Sep 2014 22:43:43 -0000 On 2014-09-10 00:22, Mathieu Arnold wrote: > > > +--On 10 septembre 2014 00:19:39 +0200 olli hauer wrote: > | On 2014-09-08 15:51, Mathieu Arnold wrote: > |> > |> > |> +--On 8 septembre 2014 13:41:54 +0000 Mark Felder > |> wrote: > |> | September 6 2014 10:24 AM, "Adam Weinberger" wrote: > |> |> apache team - > |> |> > |> |> So it seems that setting USE_APACHE=22 doesn’t actually depend on > |> |> apache-2.2. This means that every USE_APACHE=22 port is broken, and as > |> |> of right now won’t have any 10.1 packages. > |> |> > |> |> I’m happy to go through and add "DEFAULT_VERSIONS= APACHE=22” to > |> |> this ports, but I wanted to check with you guys first. Is that the > |> |> right way to fix it? Is there something else that can be done to make > |> |> USE_APACHE=22 actually depend on apache-2.2? > |> |> > |> | > |> | FYI I had to solve this problem today with the following two make.conf > |> | options: > |> | > |> | DEFAULT_VERSIONS= apache=2.2 > |> | > |> | (note it's 2.2, not 22 -- bsd.default-versions.mk shows a period should > |> | be used) > |> | > |> | APACHE_PORT= www/apache22 > |> | > |> | > |> | Previously I only had the DEFAULT_VERSIONS entry and it worked fine. > |> | Suddenly I needed to add APACHE_PORT as well. This is with an up to > |> | date ports tree -- my packages build automatically every 8 hours. > |> > |> Yes, bapt sent a patch to fix that > |> > | > | > | Based on the patch from bapt, I finished a new one (some cases where > | missing) > | https://people.freebsd.org/~ohauer/diffs/apache/bsd.apache.mk_20140909.di > | ff > | > | Perhaps someone wants to test and/or review before I commit this fix > | tomorrow. > > Using our code review tool to post this patch would have been nice, easier > to comment on, and to look at, too :-) > > Here you go: https://reviews.freebsd.org/D750 -- olli