From owner-p4-projects@FreeBSD.ORG  Thu Jan 18 14:37:06 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 5300816A51B; Thu, 18 Jan 2007 14:37:06 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 3073F16A407;
	Thu, 18 Jan 2007 14:37:06 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162])
	by mx1.freebsd.org (Postfix) with ESMTP id A979813C428;
	Thu, 18 Jan 2007 14:37:05 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7])
	(authenticated bits=0)
	by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id l0IEaq4l063039;
	Thu, 18 Jan 2007 09:36:59 -0500 (EST) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: Roman Divacky <rdivacky@freebsd.org>
Date: Thu, 18 Jan 2007 09:19:22 -0500
User-Agent: KMail/1.9.4
References: <200701180930.l0I9UAlw024022@repoman.freebsd.org>
In-Reply-To: <200701180930.l0I9UAlw024022@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200701180919.22897.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [192.168.0.1]);
	Thu, 18 Jan 2007 09:36:59 -0500 (EST)
X-Virus-Scanned: ClamAV 0.88.3/2462/Thu Jan 18 05:07:46 2007 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 
	autolearn=ham version=3.1.3
X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 113097 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jan 2007 14:37:06 -0000

On Thursday 18 January 2007 04:30, Roman Divacky wrote:
> http://perforce.freebsd.org/chv.cgi?CH=113097
> 
> Change 113097 by rdivacky@rdivacky_witten on 2007/01/18 09:29:19
> 
> 	In linux_fork and linux_vfork create the process in stopped state
> 	to be sure that the new process runs with fully initialized emuldata
> 	structure [1]. Also fix the vfork (both in linux_clone and linux_vfork)
> 	race that could result in never woken up process [2].
> 	
> 	Reported by: Scot Hetzel	[1]
> 	Suggested by: jhb		[2]

One minor nit would be to fix the comments that say '/* make it run */'
to be a full sentence (style(9)).  You can use the comment from
linux_clone() for that if you want.  The code changes look good though.

-- 
John Baldwin