From owner-svn-ports-head@freebsd.org Mon Aug 24 09:01:09 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7501F9C1758; Mon, 24 Aug 2015 09:01:09 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wi0-x22e.google.com (mail-wi0-x22e.google.com [IPv6:2a00:1450:400c:c05::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 09DD117DD; Mon, 24 Aug 2015 09:01:09 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wicne3 with SMTP id ne3so65385471wic.0; Mon, 24 Aug 2015 02:01:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=bG9av/VzUvgqiF5TENkIaof+UKke5Q+1oc87rsTKmSw=; b=fZq+vr56yk7qpRuDiRfEmtQEWFeZtCAXGh0slabjqCAOUKXxd0LUZ5aT/vT3M4CIFp 5WFDeaYNCIvz40dS/ycAOsUYd2dRzyDSfWmgvsaxYQ49MG+mH3Qdb1ZL4uX/Tuqb3XAP 6a/BFLkhhFiIk6olw/i6VRDbVyYqRy3NMlvZ61YceV0M8oCj6Lfuu7Yaa2K9DZNoDosl TZ4w+vu0S9qX9JZYqSIWa8MBK7hRsQNj2Kdzxc1/9ARwidLPYG0s+wq2SctG6/FiJYW5 GpSzDO7g+f6dwYlqfQbtOZ9ekD87hjxQ6bRRr52FGB2xfKLEAKnxnTtadaKDed2EwhPK NMNw== X-Received: by 10.194.95.71 with SMTP id di7mr38861498wjb.125.1440406867456; Mon, 24 Aug 2015 02:01:07 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id lj2sm15861168wic.1.2015.08.24.02.01.06 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Aug 2015 02:01:06 -0700 (PDT) Sender: Baptiste Daroussin Date: Mon, 24 Aug 2015 11:01:04 +0200 From: Baptiste Daroussin To: Alexey Dokuchaev Cc: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r395079 - in head/graphics: . mitsuba mitsuba/files Message-ID: <20150824090104.GB93486@ivaldir.etoilebsd.net> References: <201508230856.t7N8uwal009338@repo.freebsd.org> <96D957F8044D8B647B259802@atuin.in.mat.cc> <20150824070915.GA15244@FreeBSD.org> <20150824084807.GA93486@ivaldir.etoilebsd.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xXmbgvnjoT4axfJE" Content-Disposition: inline In-Reply-To: <20150824084807.GA93486@ivaldir.etoilebsd.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Aug 2015 09:01:09 -0000 --xXmbgvnjoT4axfJE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 24, 2015 at 10:48:07AM +0200, Baptiste Daroussin wrote: > On Mon, Aug 24, 2015 at 07:09:15AM +0000, Alexey Dokuchaev wrote: > > On Sun, Aug 23, 2015 at 11:43:21PM +0100, Mathieu Arnold wrote: > > > +--On 23 ao??t 2015 08:56:58 +0000 Alexey Dokuchaev > > > wrote: > > > | +# Unfortunately, the code is not GCC 4.2.1 compatible (due to bugs= in GCC > > > | +# itself). Try to use system compiler if it is Clang, otherwise f= allback > > > | +# to modern GCC (on older versions of FreeBSD). > > > | +.if ${OSVERSION} < 900014 > > > | +USE_GCC=3D yes > > >=20 > > > OSVERSION < 900014 will always be false. Please, don't add more chec= ks on > > > unsupported versions. > >=20 > > The fact that 8.X had reached its EOL merely means we cannot promise th= at > > things won't break. It does not mean we should immediately pull the pl= ug > > and remove two lines from the Makefile, leaving 8.4 users with a broken > > port. > >=20 > > It's up to maintainers to decide whether it's worth supporting some old > > FreeBSD version. Keeping around intricate patches and having to rebase > > and test on every update is a nuisance, so those patches probably deser= ve > > to rest in attic now. Two lines in the Makefile are hardly a burden. > >=20 > > I typically would try to support as many FreeBSD versions as long the > > port stays manageable. Often it's not a problem, and is very polite to > > our users that do not want to upgrade for some reason (e.g. me and my > > laptop are happy with stable/8 and see no reason to update, as it will > > likely pessimize work experience without bringing any benefits over 8.4= ). > >=20 > > That said, OSVERSION < 900014 will not always be false. And why do you > > want to be rude to our users and deliberately break things just because > > we no longer promise that they will work? > >=20 >=20 > Even in that case, this is wrong anyway as you enforce GCC while should s= hould > require a modern compiler via compiler.mk. >=20 > regards, > Bapt Btw that would even be nicer to only use compiler.mk feature as it will give this port a chance to work on supported freebsd version on some tiers-2 architecture which depends on gcc 4.2.1: mips, powerpc, sparc64, etc. While= your patch only gives a chance for it to work on unsupported version :) Bapt --xXmbgvnjoT4axfJE Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlXa3VAACgkQ8kTtMUmk6EwaWACgjaKd+MhMuDBs8vb078baxawI 92kAmQHCbHCKmlsW2CrkOc2qOaqWVZrl =a15C -----END PGP SIGNATURE----- --xXmbgvnjoT4axfJE--