From owner-svn-src-head@FreeBSD.ORG Wed May 18 21:38:55 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 26267106564A; Wed, 18 May 2011 21:38:55 +0000 (UTC) (envelope-from mdf356@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id B21D78FC18; Wed, 18 May 2011 21:38:53 +0000 (UTC) Received: by wwc33 with SMTP id 33so2153174wwc.31 for ; Wed, 18 May 2011 14:38:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=fSkXHjfLfG/Xh7QdtRtr7o/jG3yUf8pNwUlcOpgN+sg=; b=ZasQebzXKuXi0cu5St8j17qNhn1lqR8N4ZUZzWaucZDTxZH1xLNhWwbjY2dEmszJ19 aiNXg6qH7ZDwUlEeeBnU+yJBxDQ6lElwKKY4SEfeIUuDW9MZcrI7KOXWKUD5ckp5FyKk EN1VhxKI8zjnreDaF3N+NUfcmiMHVAnBptC5c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=x2Xws8DFQoSKNaGsv1mXrvB3ANMofuIdjOs4G4i4uafDaUjILbNAtVrno9H64ZLnNe FDiZscdJLm4cERs01oenfONDFXrVJxQYjq0iL6iNzOsge7LkPCrZ5CAIRU6JM6A1DERD wnGR1BD4lm1M3X56hT5iQsiItm9X0Ndo4+yLQ= MIME-Version: 1.0 Received: by 10.216.79.10 with SMTP id h10mr2302544wee.20.1305754732765; Wed, 18 May 2011 14:38:52 -0700 (PDT) Sender: mdf356@gmail.com Received: by 10.216.153.104 with HTTP; Wed, 18 May 2011 14:38:52 -0700 (PDT) In-Reply-To: <4DD43AB7.7060705@FreeBSD.org> References: <201105182106.p4IL6KkE008657@svn.freebsd.org> <20110518211651.GE2273@garage.freebsd.pl> <4DD43AB7.7060705@FreeBSD.org> Date: Wed, 18 May 2011 14:38:52 -0700 X-Google-Sender-Auth: ByVMmZRxMpUw8M3JIdXfR78tKWQ Message-ID: From: mdf@FreeBSD.org To: Dimitry Andric Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Ben Laurie , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Pawel Jakub Dawidek Subject: Re: svn commit: r222084 - head/contrib/gperf/src X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 May 2011 21:38:55 -0000 On Wed, May 18, 2011 at 2:31 PM, Dimitry Andric wrote: > On 2011-05-18 23:16, Pawel Jakub Dawidek wrote: >> >> On Wed, May 18, 2011 at 09:06:20PM +0000, Ben Laurie wrote: >>> >>> Author: benl >>> Date: Wed May 18 21:06:20 2011 >>> New Revision: 222084 >>> URL: http://svn.freebsd.org/changeset/base/222084 >>> >>> Log: >>> =A0 Fix clang warnings. >>> >>> =A0 Approved by: philip (mentor) >> >> [...] >>> >>> - =A0 =A0 =A0 =A0 =A0 =A0fprintf (stderr, " by changing asso_value['%c'= ] (char #%d) >>> to %d\n", >>> + =A0 =A0 =A0 =A0 =A0 =A0fprintf (stderr, " by changing asso_value['%c'= ] (char #%zd) >>> to %d\n", >>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 *p, p - union_set + 1, asso= _values[(unsigned >>> char)(*p)]); >> >> Hmm, both 'p' and 'union_set' are 'char *' and %zd is for ssize_t. It is >> a bit strange that it fixes the warning. > > If you subtract two pointers, such as in this case, you get a ptrdiff_t. > > Strictly, this doesn't have to be exactly the same type as ssize_t, but > in practice it will almost always be. > > You can also cast the result to intmax_t, and use %jd, then it will > always be correct, but possibly have some small overhead. Or you can use %td which is the C99 conversion specifier for ptrdiff_t. Thanks, matthew