From owner-svn-src-head@freebsd.org  Thu Aug 17 20:41:30 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0E613DD5CEC;
 Thu, 17 Aug 2017 20:41:30 +0000 (UTC)
 (envelope-from ngie@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id CD01163D9E;
 Thu, 17 Aug 2017 20:41:29 +0000 (UTC)
 (envelope-from ngie@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v7HKfS2j028254;
 Thu, 17 Aug 2017 20:41:28 GMT (envelope-from ngie@FreeBSD.org)
Received: (from ngie@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id v7HKfSZw028253;
 Thu, 17 Aug 2017 20:41:28 GMT (envelope-from ngie@FreeBSD.org)
Message-Id: <201708172041.v7HKfSZw028253@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: ngie set sender to
 ngie@FreeBSD.org using -f
From: Ngie Cooper <ngie@FreeBSD.org>
Date: Thu, 17 Aug 2017 20:41:28 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r322636 - head/usr.sbin/bootparamd/bootparamd
X-SVN-Group: head
X-SVN-Commit-Author: ngie
X-SVN-Commit-Paths: head/usr.sbin/bootparamd/bootparamd
X-SVN-Commit-Revision: 322636
X-SVN-Commit-Repository: base
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Aug 2017 20:41:30 -0000

Author: ngie
Date: Thu Aug 17 20:41:28 2017
New Revision: 322636
URL: https://svnweb.freebsd.org/changeset/base/322636

Log:
  Don't leak bpf on early return when YP isn't defined (NIS support)
  
  MFC after:	1 week
  Reported by:	cppcheck

Modified:
  head/usr.sbin/bootparamd/bootparamd/bootparamd.c

Modified: head/usr.sbin/bootparamd/bootparamd/bootparamd.c
==============================================================================
--- head/usr.sbin/bootparamd/bootparamd/bootparamd.c	Thu Aug 17 20:37:01 2017	(r322635)
+++ head/usr.sbin/bootparamd/bootparamd/bootparamd.c	Thu Aug 17 20:41:28 2017	(r322636)
@@ -239,6 +239,8 @@ int blen;
         warnx("could not close %s", bootpfile);
       return(1);
 #else
+      if (fclose(bpf))
+        warnx("could not close %s", bootpfile);
       return(0);	/* ENOTSUP */
 #endif
     }