Date: Wed, 6 Nov 2019 09:56:21 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Russell Haley <russ.haley@gmail.com> Cc: freebsd-ports@freebsd.org Subject: Re: Adding FLAVORS to lua-luarocks Message-ID: <20191106085621.6ghgryrttdgb442z@ivaldir.net> In-Reply-To: <CABx9NuSX8mGXfemkeVMAncBkwWogWE5ewtC1M-yeFuAw3nC-Jg@mail.gmail.com> References: <CABx9NuSX8mGXfemkeVMAncBkwWogWE5ewtC1M-yeFuAw3nC-Jg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--omrkt4mvgtzsx372 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 05, 2019 at 09:43:48PM -0800, Russell Haley wrote: > Hello, >=20 > I have a review for updating the Lua package manager - LuaRocks - it to t= he > latest revision, 3.2.1. The new port file uses an update to lua.mk from > Andrew Gierth for using FLAVORS to support all available versions of Lua. > The reviews are here: (LuaRocks) https://reviews.freebsd.org/D17814 and > here: (Lua.mk) https://reviews.freebsd.org/D16494 >=20 > In the LuaRocks port, I've added the flavors as a selection of port OPTIO= NS > to build the correct version. Unfortunately, using the OPTIONS isn't ideal > because it will save the selected option for the next time the port is ru= n, > but that's not the desired use case. I wanted the build to *always* prompt > for a Lua version so it can be used for multiple side by side Lua > installations. >=20 > Any suggestions, alternatives to OPTIONS or other constructive input would > be appreciated. >=20 If the lua.mk ever get the support for flavors committed in, there is no ne= ed to add any option framework or whatever to allow the user to pickup a flavor. if someone $ants to only build for a given flavor he will have to just to r= un: make FLAVOR=3Dlua52 if building from poudriere: poudriere bulk devel/lua-rocks@lua52 Best regards, Bapt --omrkt4mvgtzsx372 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAl3CipcACgkQY4mL3PG3 PlrRYxAAnPoydn/3GQt67bdKUKhItyEdCvGF0vuci0OhG7sbFbnA8my3oRa702LX lSFENQESQYFLRphNPxaCGGCaItigUMXpUlmI57uvYILxqxLl7WUrS2VNH/RNdEn8 TTU4RCqhERRatwihZ8S7/hxtfRyGHpilD77ujoxtgIkL85Gl6va6O9lYcrdRaoHM qUBU8YJlbzUoLRM5fjUoIbT+iUoakiwFkk6EU9smDRIo3YQsXAT6D9YfMWZD0/2u 7PIMT8g+TUwp6sdMwm+WXk1FnltFRsMkf4LSxLoiqRky2pkqeFYCGM9h3k18iClI 8UiYc0hhzTVrygYQb4wEqlTG6N8bd14ljH3WGiQ7yLg9YBHqiS41QdXN8l86uNEK x4GBX23HmKiXelaSHqQnKbAcSkqgOH3WEKQAZhb6MrplsBXTJohF60muPU3suNsQ Z62YvtIGjGLulKMrtR5mH26vUBCza0z/9W9e7NQwjOJxQLaLFvC+YNitHIj1TGfW PxucbiILaGaAFEFXxusE8p0Nho7ZV+0QriKJIqYWx+CE5tFpKF1AHMditkDFZXUf pf+xJmwsh83/NFUYmODFR0/ioy/oJmq0Oz7Y0P7cBXzIKzy51pYYkHuuBJEKiFuq VGY9pgU3gZ7I5nEySwG+DvKrjxN06p9d9YnqOkytzvhghiuknhU= =Po3y -----END PGP SIGNATURE----- --omrkt4mvgtzsx372--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191106085621.6ghgryrttdgb442z>