Date: Tue, 11 Jul 2017 02:53:37 +0800 From: Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> To: Torsten Zuehlsdorff <tz@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r445432 - head/net/rubygem-grpc Message-ID: <CAMHz58TJRXBb2Q4mu-VgBjiAbRhhv5h30Y3CyUSD6TqOd_jqyA@mail.gmail.com> In-Reply-To: <201707101208.v6AC8Ox4069370@repo.freebsd.org> References: <201707101208.v6AC8Ox4069370@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jul 10, 2017 at 8:08 PM, Torsten Zuehlsdorff <tz@freebsd.org> wrote: > Author: tz > Date: Mon Jul 10 12:08:24 2017 > New Revision: 445432 > URL: https://svnweb.freebsd.org/changeset/ports/445432 > > Log: > net/rubygem-grpc: Add missing BUILD_DEPENDS > > Add needed build dependencies. > > This wasn't spotted before since poudriere pulls > in all RUN_DEPENDS before building, but portmaster didn't. > > PR: 220567 > Submitted by: hakan@siktas.com > MFH: 2017Q3 > Hello Torsten, You do not need to bump PORTREVISION when adding BUILD_DEPENDS. And it would be better to remove blank lines among *_DEPENDS (and sort them). Regards, sunpoet > > Modified: > head/net/rubygem-grpc/Makefile > > Modified: head/net/rubygem-grpc/Makefile > ============================================================ > ================== > --- head/net/rubygem-grpc/Makefile Mon Jul 10 12:03:06 2017 > (r445431) > +++ head/net/rubygem-grpc/Makefile Mon Jul 10 12:08:24 2017 > (r445432) > @@ -2,6 +2,7 @@ > > PORTNAME= grpc > PORTVERSION= 1.4.0 > +PORTREVISION= 1 > CATEGORIES= net rubygems > MASTER_SITES= RG > > @@ -14,7 +15,11 @@ RUN_DEPENDS= ca_root_nss>=0:security/ca_root_nss \ > grpc>=0:devel/grpc \ > rubygem-google-protobuf>=3.0:devel/rubygem-google-protobuf > \ > rubygem-googleauth>=0.5.1:security/rubygem-googleauth > + > LIB_DEPENDS= libcares.so:dns/c-ares > + > +BUILD_DEPENDS= ca_root_nss>=0:security/ca_root_nss \ > + grpc>=0:devel/grpc > > MAKE_JOBS_UNSAFE=yes > > _______________________________________________ > svn-ports-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-ports-all > To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58TJRXBb2Q4mu-VgBjiAbRhhv5h30Y3CyUSD6TqOd_jqyA>