From owner-svn-src-head@FreeBSD.ORG Tue Jul 19 02:31:10 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 42FFD106566C; Tue, 19 Jul 2011 02:31:10 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-gy0-f182.google.com (mail-gy0-f182.google.com [209.85.160.182]) by mx1.freebsd.org (Postfix) with ESMTP id CCA048FC15; Tue, 19 Jul 2011 02:31:09 +0000 (UTC) Received: by gyf3 with SMTP id 3so1950964gyf.13 for ; Mon, 18 Jul 2011 19:31:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=sDDCNl+GW5DsNkQqWaxjTWyz5Q1m/kDu2HNK+BdQook=; b=ilyH8DKqQ26Gf2baF17rUPQn6qZwkHpTxrESkn/gzs8fR5OaUpNNO2AH5Bz4D+ZALR D6TZ8GzD4nQtWnk/t5zs0ozibdybHKdNNe/74zZVAVkZI1HFDZd5LCXRAfGjNwu/RmQn c0AwE1aFtfFxTrNwh/0bmohiFvKOiSH91oNhE= MIME-Version: 1.0 Received: by 10.236.147.111 with SMTP id s75mr139497yhj.272.1311042669108; Mon, 18 Jul 2011 19:31:09 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.236.105.169 with HTTP; Mon, 18 Jul 2011 19:31:09 -0700 (PDT) In-Reply-To: References: <201107181519.p6IFJfOK028280@svn.freebsd.org> <208D139E-CDC3-428D-8D5F-F772BFAF164C@xcllnt.net> Date: Tue, 19 Jul 2011 04:31:09 +0200 X-Google-Sender-Auth: s3OYTxTmICxTmIu32grTqSV21zQ Message-ID: From: Attilio Rao To: Marcel Moolenaar Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r224187 - in head: sys/amd64/amd64 sys/arm/arm sys/arm/sa11x0 sys/i386/i386 sys/ia64/ia64 sys/kern sys/mips/mips sys/powerpc/aim sys/powerpc/booke sys/sparc64/sparc64 sys/sys usr.bin/vm... X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2011 02:31:10 -0000 2011/7/19 Marcel Moolenaar : > > On Jul 18, 2011, at 5:59 PM, Attilio Rao wrote: > >> 2011/7/19 Marcel Moolenaar : >>> >>> On Jul 18, 2011, at 8:19 AM, Attilio Rao wrote: >>> >>>> Author: attilio >>>> Date: Mon Jul 18 15:19:40 2011 >>>> New Revision: 224187 >>>> URL: http://svn.freebsd.org/changeset/base/224187 >>>> >>>> Log: >>>> =C2=A0- Remove the eintrcnt/eintrnames usage and introduce the concept= of >>>> =C2=A0 =C2=A0sintrcnt/sintrnames which are symbols containing the size= of the 2 >>>> =C2=A0 =C2=A0tables. >>>> =C2=A0- For amd64/i386 remove the storage of intr* stuff from assembly= files. >>>> =C2=A0 =C2=A0This area can be widely improved by applying the same to = other >>>> =C2=A0 =C2=A0architectures and likely finding an unified approach amon= g them and >>>> =C2=A0 =C2=A0move the whole code to be MI. More work in this area is e= xpected to >>>> =C2=A0 =C2=A0happen fairly soon. >>>> >>>> =C2=A0No MFC is previewed for this patch. >>> >>> You just broke ia64 and possibly other 64-bit architectures: >>> >>> ".word" declares a 16-bit integral on ia64 and the size symbols >>> are of type size_t (=3D64 bit). We'll be having misaligned loads >>> (=3D kernel panics) and/or reading garbage... >> >> I'm a bit surprised of this though. >> .hword was supposed to be the 16-bit integral, while .word was >> supposed to be the 32-bits one, if I read my "info as" on amd64. > > Well... all I can say is that assembly is the least transposable > language, besides of course machine code itself :-) > >> Anyway, what do you think about this patch? (I still need to test it): >> http://www.freebsd.org/~attilio/64bits-fixup.diff > > Looks good to me, though I don't know enough about mips to comment > on that. I'm not going to be anal about the use of ".quad" instead > of "data8" for ia64 -- let's get it fixed first (I think we have > ".byte" in locore.S anyway :-) We do. Anyway, I've updated the patch in order to use data8 in ia64 case (you are the maintainer, so you have the last word) even if I'm not sure there is a real need to discourage .quad. Thanks for pointing at this breakage, please review and approve in case. Attilio --=20 Peace can only be achieved by understanding - A. Einstein