From owner-cvs-src@FreeBSD.ORG Thu Nov 30 21:18:39 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E304116A49E; Thu, 30 Nov 2006 21:18:39 +0000 (UTC) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.FreeBSD.org (Postfix) with ESMTP id E239A4408F; Thu, 30 Nov 2006 21:10:08 +0000 (GMT) (envelope-from sam@errno.com) Received: from [10.0.0.248] (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id kAUL9mW3030683 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 30 Nov 2006 13:09:51 -0800 (PST) (envelope-from sam@errno.com) Message-ID: <456F489C.90603@errno.com> Date: Thu, 30 Nov 2006 13:09:48 -0800 From: Sam Leffler User-Agent: Thunderbird 1.5.0.7 (X11/20060920) MIME-Version: 1.0 To: Scott Long References: <200611301502.kAUF22lU076210@repoman.freebsd.org> <456F0B71.3050604@errno.com> <456F1F6F.3080407@samsco.org> In-Reply-To: <456F1F6F.3080407@samsco.org> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, Gleb Smirnoff , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/net if.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2006 21:18:40 -0000 Scott Long wrote: > Sam Leffler wrote: >> Gleb Smirnoff wrote: >> >>> glebius 2006-11-30 15:02:01 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/net if.c Log: >>> The recent issues with em(4) interface has shown that the old 4.4BSD >>> if_watchdog/if_timer interface doesn't fit modern SMP network >>> stack design. >>> >>> Device drivers that need watchdog to monitor their hardware should >>> implement it theirselves. >>> >>> Eventually the if_watchdog/if_timer API will be removed. For now, >>> warn that driver uses it. >>> >>> Reviewed by: scottl >> >> >> Did I miss a headsup on this? Seems like something you should >> coordinate with folks so people can convert drivers beforehand. I >> understand the problem and I see this is just a printf but now we're >> going to have people asking what's going on. >> >> Sam > > I didn't expect Gleb to act so quickly on this, but I'm very glad that > he did. Sorry it was a suprise. Would it help if he or I added an > UPDATING entry and a mailing list announcement about it? Please publicize this with at least a posting to current@ so people do not start asking questions (well, at least more questions--we know not everyone will see a posting and/or pay attention). Converting if_watchdog to callout's is mostly mechanical in the wired nic drivers. For wireless drivers it is not as straightforward. In particular I'm a little leary of usb wireless drivers due to layering and the Giant locking in the usb code. OTOH most of the drivers were already so broken in this area that it probably doesn't hurt to do mechanical-like changes now (though I worry people will fire-and-forget to really fix the issues). Sam