From owner-cvs-all Sun Dec 15 7: 4:53 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AD83437B401; Sun, 15 Dec 2002 07:04:52 -0800 (PST) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1FB7943EB2; Sun, 15 Dec 2002 07:04:52 -0800 (PST) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.12.6/8.12.5) with SMTP id gBFF4hBF061505; Sun, 15 Dec 2002 10:04:44 -0500 (EST) (envelope-from robert@fledge.watson.org) Date: Sun, 15 Dec 2002 10:04:42 -0500 (EST) From: Robert Watson X-Sender: robert@fledge.watson.org To: Maxim Konovalov Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_dummynet.c In-Reply-To: <200212151021.gBFALV1Y040756@repoman.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG I've noticed this in some other places in the code, and was confused about it myself for a bit. Part of the problem is that the flags appear to come from the same namespace. It should be easy enough to catch this though by temporarily diverging the values of the flags and making sure there are asserts in the appropriate calls that consume the flags. Alternatively, would could combine the flags... :-) Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Network Associates Laboratories On Sun, 15 Dec 2002, Maxim Konovalov wrote: > maxim 2002/12/15 02:21:31 PST > > Modified files: > sys/netinet ip_dummynet.c > Log: > o M_DONTWAIT is mbuf(9) flag: malloc(M_DONTWAIT) -> malloc(M_NOWAIT). > The bug does not affect anything because M_NOWAIT == M_DONTWAIT. > > Reviewed by: luigi > MFC after: 1 week > > Revision Changes Path > 1.57 +7 -7 src/sys/netinet/ip_dummynet.c > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message