From owner-cvs-all Fri Apr 17 21:27:00 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id VAA23936 for cvs-all-outgoing; Fri, 17 Apr 1998 21:27:00 -0700 (PDT) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from spinner.netplex.com.au ([202.12.86.3]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id EAA22797; Sat, 18 Apr 1998 04:12:11 GMT (envelope-from peter@netplex.com.au) Received: from spinner.netplex.com.au (localhost [127.0.0.1]) by spinner.netplex.com.au (8.8.8/8.8.8/Spinner) with ESMTP id MAA16043; Sat, 18 Apr 1998 12:11:21 +0800 (WST) (envelope-from peter@spinner.netplex.com.au) Message-Id: <199804180411.MAA16043@spinner.netplex.com.au> X-Mailer: exmh version 2.0.2 2/24/98 To: "Dag-Erling C. Sm\xf8rgrav" cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/dpt dpt_control.c src/sys/gnu/ext2fs... In-reply-to: Your message of "Fri, 17 Apr 1998 15:37:21 MST." <199804172237.PAA12467@freefall.freebsd.org> Date: Sat, 18 Apr 1998 12:11:20 +0800 From: Peter Wemm Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk "Dag-Erling C. Sm\xf8rgrav" wrote: > des 1998/04/17 15:37:20 PDT > > Modified files: > sys/dev/dpt dpt_control.c > sys/gnu/ext2fs COPYRIGHT.INFO ext2_alloc.c ext2_vnops.c [..] > sys/ufs/ufs ufs_vnops.c > Log: > Seventy-odd "its" / "it's" typos in comments fixed as per kern/6108. What the hell??? I don't call this "fixing typos", as far as I can tell, most of these changes have broken the correct usage. eg: here, we are talking about the device's softc: +++ dpt_control.c 1998/03/23 10:49:01 @@ -175,7 +175,7 @@ /** * Given a minor device number, - * return the pointer to it's softc structure + * return the pointer to its softc structure */ static INLINE dpt_softc_t * eg: here we are talking about the card's EEROM. +++ if_ed.c 1998/03/23 11:05:46 @@ -676,7 +676,7 @@ #endif DELAY(100); outb(sc->asic_addr + ED_WD_MSR, inb(sc->asic_addr + ED_WD_MSR) & ~ED_WD_ MSR_RST); - /* wait in the case this card is reading it's EEROM */ + /* wait in the case this card is reading its EEROM */ DELAY(5000); sc->vendor = ED_VENDOR_WD_SMC; And so on... Just because a PR is submitted, it doesn't mean it's right. If they were always right, there would be an automatic patch application process on PR submission. -Peter To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message