Date: Thu, 7 Jul 2011 06:43:22 -0600 From: PseudoCylon <moonlightakkiy@yahoo.ca> To: Hans Petter Selasky <hselasky@c2i.net> Cc: freebsd-current@freebsd.org, "freebsd-wireless@freebsd.org" <freebsd-wireless@freebsd.org> Subject: Re: [CFT] Sierra Wireless HSPA+ USB modem Message-ID: <CAFZ_MYKcHPJxA266ECUD1nvsy0NBEgGYaRFxg5jC9Fi4qSpGSw@mail.gmail.com> In-Reply-To: <201107061719.38445.hselasky@c2i.net> References: <1309237117.88943.YahooMailNeo@web39307.mail.mud.yahoo.com> <201106280850.57645.hselasky@c2i.net> <201107061719.38445.hselasky@c2i.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 6, 2011 at 9:19 AM, Hans Petter Selasky <hselasky@c2i.net> wrote: >> >> Hi, >> >> I'm going to review and import your driver. >> >> --HPS > > Hi, > > The intial patch had some bad code and didn't compile on 9-current. I've tried > to clean it up. Please test and report back if I didn't break anything. > > http://hselasky.homeunix.org:8192/usie_for_FreeBSD_9_current.patch > > --HPS > Hello, Thanks for the patch. if_usie.c 241 if (usbd_lookup_id_by_uaa(usie_devs, sizeof(usie_devs), uaa) != 0) 242 return; /* no device match */ It should return non-zero on success, but somehow this caused the process to exit, and modem stayed being a CD-ROM. The compiler complained about uninitialized int if_usie.c: 1484 - uint8_t pad; + uint8_t pad = 0; Otherwise it worked fine. AK
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFZ_MYKcHPJxA266ECUD1nvsy0NBEgGYaRFxg5jC9Fi4qSpGSw>