From owner-svn-src-all@FreeBSD.ORG Sun Mar 15 20:30:04 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D660B42D; Sun, 15 Mar 2015 20:30:04 +0000 (UTC) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C2911F2E; Sun, 15 Mar 2015 20:30:04 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.9/8.14.9) with ESMTP id t2FKU4E1059708; Sun, 15 Mar 2015 20:30:04 GMT (envelope-from adrian@FreeBSD.org) Received: (from adrian@localhost) by svn.freebsd.org (8.14.9/8.14.9/Submit) id t2FKU4c3059707; Sun, 15 Mar 2015 20:30:04 GMT (envelope-from adrian@FreeBSD.org) Message-Id: <201503152030.t2FKU4c3059707@svn.freebsd.org> X-Authentication-Warning: svn.freebsd.org: adrian set sender to adrian@FreeBSD.org using -f From: Adrian Chadd Date: Sun, 15 Mar 2015 20:30:04 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r280065 - head/sys/dev/wpi X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Mar 2015 20:30:04 -0000 Author: adrian Date: Sun Mar 15 20:30:03 2015 New Revision: 280065 URL: https://svnweb.freebsd.org/changeset/base/280065 Log: wpi_intr(): remove duplicate code PR: kern/197143 Submitted by: Andriy Voskoboinyk Modified: head/sys/dev/wpi/if_wpi.c Modified: head/sys/dev/wpi/if_wpi.c ============================================================================== --- head/sys/dev/wpi/if_wpi.c Sun Mar 15 20:29:22 2015 (r280064) +++ head/sys/dev/wpi/if_wpi.c Sun Mar 15 20:30:03 2015 (r280065) @@ -2195,10 +2195,8 @@ wpi_intr(void *arg) r1 = WPI_READ(sc, WPI_INT); - if (r1 == 0xffffffff || (r1 & 0xfffffff0) == 0xa5a5a5a0) { - WPI_UNLOCK(sc); - return; /* Hardware gone! */ - } + if (r1 == 0xffffffff || (r1 & 0xfffffff0) == 0xa5a5a5a0) + goto end; /* Hardware gone! */ r2 = WPI_READ(sc, WPI_FH_INT); @@ -2222,8 +2220,7 @@ wpi_intr(void *arg) "(Hardware Error)"); ieee80211_runtask(ic, &sc->sc_reinittask); sc->flags &= ~WPI_FLAG_BUSY; - WPI_UNLOCK(sc); - return; + goto end; } if ((r1 & (WPI_INT_FH_RX | WPI_INT_SW_RX)) || @@ -2241,7 +2238,7 @@ done: if (ifp->if_flags & IFF_UP) WPI_WRITE(sc, WPI_INT_MASK, WPI_INT_MASK_DEF); - WPI_UNLOCK(sc); +end: WPI_UNLOCK(sc); } static int