Date: Tue, 12 Dec 2017 11:27:13 -0800 From: Cy Schubert <Cy.Schubert@komquats.com> To: Mateusz Guzik <mjguzik@gmail.com>, Warner Losh <imp@bsdimp.com> Cc: Antoine Brodin <antoine@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, src-committers <src-committers@freebsd.org> Subject: RE: svn commit: r326792 - head/stand/uboot/common Message-ID: <20171212192709.3D13A5F1@spqr.komquats.com>
next in thread | raw e-mail | index | archive | help
PR 224080??? --- Sent using a tiny phone keyboard. Apologies for any typos and autocorrect. Also, this old phone only supports top post. Apologies. Cy Schubert <Cy.Schubert@cschubert.com> or <cy@freebsd.org> The need of the many outweighs the greed of the few. --- -----Original Message----- From: Mateusz Guzik Sent: 12/12/2017 11:13 To: Warner Losh Cc: Antoine Brodin; svn-src-head@freebsd.org; svn-src-all@freebsd.org; src-= committers Subject: Re: svn commit: r326792 - head/stand/uboot/common How about you both close one PR as a punishment and we pretend this did not happen. The thing to do was to reply to the offending commit or contact the committ= er on irc. Only in case of no timely response fixing on your own is the right = thing to do. On Tue, Dec 12, 2017 at 8:03 PM, Warner Losh <imp@bsdimp.com> wrote: The email I wrote here also sucks. It was unduly harsh. While the commit message should have been better, I was too harsh in trying to express this and giving a better example. =20 Warner =20 On Tue, Dec 12, 2017 at 5:49 AM, Warner Losh <imp@bsdimp.com> wrote: =20 > This commit message sucks. Please use a more descriptive one in the futur= e > like "catch up to change rXXXXX that remove the argument from interact."= If > you want to be snarky, add 'pounty hat to imp' to it. Thats infornative. > Your message is utterly useless. It doesn't even say what arch is broken= . > > Warner > > Warner > > On Dec 12, 2017 1:47 AM, "Antoine Brodin" <antoine@freebsd.org> wrote: > >> Author: antoine >> Date: Tue Dec 12 09:46:53 2017 >> New Revision: 326792 >> URL: https://svnweb.freebsd.org/changeset/base/326792 >> >> Log: >> Attempt to unbreak buildworld >> >> Modified: >> head/stand/uboot/common/main.c >> >> Modified: head/stand/uboot/common/main.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- head/stand/uboot/common/main.c Tue Dec 12 06:56:21 2017 >> (r326791) >> +++ head/stand/uboot/common/main.c Tue Dec 12 09:46:53 2017 >> (r326792) >> @@ -500,7 +500,7 @@ main(int argc, char **argv) >> archsw.arch_readin =3D uboot_readin; >> archsw.arch_autoload =3D uboot_autoload; >> >> - interact(NULL); /* doesn't return */ >> + interact(); /* doesn't return */ >> >> return (0); >> } >> >> _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" =20 --=20 Mateusz Guzik <mjguzik gmail.com> =
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171212192709.3D13A5F1>