Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 02 Feb 2016 11:39:46 -0800
From:      John Baldwin <jhb@freebsd.org>
To:        Alfred Perlstein <alfred@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r295136 - in head: sys/kern sys/netinet sys/sys usr.bin/netstat
Message-ID:  <36439709.poT7RgRunK@ralph.baldwin.cx>
In-Reply-To: <201602020557.u125vxCP084718@repo.freebsd.org>
References:  <201602020557.u125vxCP084718@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, February 02, 2016 05:57:59 AM Alfred Perlstein wrote:
> Author: alfred
> Date: Tue Feb  2 05:57:59 2016
> New Revision: 295136
> URL: https://svnweb.freebsd.org/changeset/base/295136
> 
> Log:
>   Increase max allowed backlog for listen sockets
>   from short to int.
>   
>   PR: 203922
>   Submitted by: White Knight <white_knight@2ch.net>
>   MFC After: 4 weeks

You do realize that this breaks the ABI of the sysctls used to fetch
connection lists (and so will break existing binaries like ucd-snmpd, etc.)
and thus can't be MFC'd right?

Also, when this patch was brought up on the lists there was the question of
if it is really beneficial to have more than 32k sockets that you haven't
accepted yet.  It's one thing to have lots of concurrent active sockets that
you are servicing, but if your application is so backlogged that there are
32k sockets waiting on accept() it's hard to imagine why having more than
32k sockets waiting on accept() is useful.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?36439709.poT7RgRunK>