Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 20 Sep 2000 07:16:25 +0100
From:      Brian Somers <brian@Awfulhak.org>
To:        Poul-Henning Kamp <phk@critter.freebsd.dk>
Cc:        Brian Somers <brian@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@Awfulhak.org
Subject:   Re: cvs commit: src/lib/libc/stdlib malloc.c setenv.c 
Message-ID:  <200009200616.e8K6GPs13592@hak.lan.Awfulhak.org>
In-Reply-To: Message from Poul-Henning Kamp <phk@critter.freebsd.dk>  of "Wed, 20 Sep 2000 07:42:40 %2B0200." <94347.969428560@critter> 

next in thread | previous in thread | raw e-mail | index | archive | help
> In message <200009200305.UAA32271@freefall.freebsd.org>, Brian Somers writes:
> >brian       2000/09/19 20:05:38 PDT
> >
> >  Modified files:
> >    lib/libc/stdlib      malloc.c setenv.c 
> >  Log:
> >  Only realloc() environ if we're sure that we know where it came from.
> >  
> >  The recent problems with sshd were due to sshd reassigning
> >  `environ' when setenv() thinks it owns it.  setenv() subsequently
> >  realloc()s the new version of environ and *boom*
> 
> Uhm, Brian ?  Could you please remove EXTRA_SANITY in malloc.c again ?

*GASP*..... sh*t !

Thanks.

> --
> Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
> phk@FreeBSD.ORG         | TCP/IP since RFC 956
> FreeBSD coreteam member | BSD since 4.3-tahoe    
> Never attribute to malice what can adequately be explained by incompetence.

-- 
Brian <brian@Awfulhak.org>                        <brian@[uk.]FreeBSD.org>
      <http://www.Awfulhak.org>;                   <brian@[uk.]OpenBSD.org>
Don't _EVER_ lose your sense of humour !




To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200009200616.e8K6GPs13592>