Skip site navigation (1)Skip section navigation (2) 
Date:      Fri, 21 Dec 2018 16:06:25 +0000 (UTC)
From:      Andrew Rybchenko <arybchik@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org
Subject:   svn commit: r342325 - stable/12/sys/dev/sfxge/common
Message-ID:  <201812211606.wBLG6P9R068744@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: arybchik
Date: Fri Dec 21 16:06:25 2018
New Revision: 342325
URL: https://svnweb.freebsd.org/changeset/base/342325

Log:
  MFC r340889
  
  sfxge(4): fix warnings from VS2015 C compiler (C4189)
  
  Fix multiple level 4 warnings
  "C4189: 'xxx': local variable is initialized but not referenced";
  no functional changes.
  
  Submitted by:   Andrew Lee <alee at solarflare.com>
  Sponsored by:   Solarflare Communications, Inc.
  Differential Revision:  https://reviews.freebsd.org/D18123

Modified:
  stable/12/sys/dev/sfxge/common/ef10_ev.c
  stable/12/sys/dev/sfxge/common/efx_ev.c
  stable/12/sys/dev/sfxge/common/efx_tx.c
  stable/12/sys/dev/sfxge/common/mcdi_mon.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/dev/sfxge/common/ef10_ev.c
==============================================================================
--- stable/12/sys/dev/sfxge/common/ef10_ev.c	Fri Dec 21 16:02:29 2018	(r342324)
+++ stable/12/sys/dev/sfxge/common/ef10_ev.c	Fri Dec 21 16:06:25 2018	(r342325)
@@ -576,7 +576,7 @@ ef10_ev_qdestroy(
 	EFSYS_ASSERT(enp->en_family == EFX_FAMILY_HUNTINGTON ||
 	    enp->en_family == EFX_FAMILY_MEDFORD);
 
-	(void) efx_mcdi_fini_evq(eep->ee_enp, eep->ee_index);
+	(void) efx_mcdi_fini_evq(enp, eep->ee_index);
 }
 
 	__checkReturn	efx_rc_t
@@ -1255,6 +1255,7 @@ ef10_ev_rxlabel_init(
 {
 	efx_evq_rxq_state_t *eersp;
 
+	_NOTE(ARGUNUSED(type))
 	EFSYS_ASSERT3U(label, <, EFX_ARRAY_SIZE(eep->ee_rxq_state));
 	eersp = &eep->ee_rxq_state[label];
 

Modified: stable/12/sys/dev/sfxge/common/efx_ev.c
==============================================================================
--- stable/12/sys/dev/sfxge/common/efx_ev.c	Fri Dec 21 16:02:29 2018	(r342324)
+++ stable/12/sys/dev/sfxge/common/efx_ev.c	Fri Dec 21 16:06:25 2018	(r342325)
@@ -228,14 +228,14 @@ efx_ev_qcreate(
 	__deref_out	efx_evq_t **eepp)
 {
 	const efx_ev_ops_t *eevop = enp->en_eevop;
-	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);
 	efx_evq_t *eep;
 	efx_rc_t rc;
 
 	EFSYS_ASSERT3U(enp->en_magic, ==, EFX_NIC_MAGIC);
 	EFSYS_ASSERT3U(enp->en_mod_flags, &, EFX_MOD_EV);
 
-	EFSYS_ASSERT3U(enp->en_ev_qcount + 1, <, encp->enc_evq_limit);
+	EFSYS_ASSERT3U(enp->en_ev_qcount + 1, <,
+	    enp->en_nic_cfg.enc_evq_limit);
 
 	switch (flags & EFX_EVQ_FLAGS_NOTIFY_MASK) {
 	case EFX_EVQ_FLAGS_NOTIFY_INTERRUPT:

Modified: stable/12/sys/dev/sfxge/common/efx_tx.c
==============================================================================
--- stable/12/sys/dev/sfxge/common/efx_tx.c	Fri Dec 21 16:02:29 2018	(r342324)
+++ stable/12/sys/dev/sfxge/common/efx_tx.c	Fri Dec 21 16:06:25 2018	(r342325)
@@ -303,14 +303,14 @@ efx_tx_qcreate(
 	__out		unsigned int *addedp)
 {
 	const efx_tx_ops_t *etxop = enp->en_etxop;
-	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);
 	efx_txq_t *etp;
 	efx_rc_t rc;
 
 	EFSYS_ASSERT3U(enp->en_magic, ==, EFX_NIC_MAGIC);
 	EFSYS_ASSERT3U(enp->en_mod_flags, &, EFX_MOD_TX);
 
-	EFSYS_ASSERT3U(enp->en_tx_qcount + 1, <, encp->enc_txq_limit);
+	EFSYS_ASSERT3U(enp->en_tx_qcount + 1, <,
+	    enp->en_nic_cfg.enc_txq_limit);
 
 	/* Allocate an TXQ object */
 	EFSYS_KMEM_ALLOC(enp->en_esip, sizeof (efx_txq_t), etp);

Modified: stable/12/sys/dev/sfxge/common/mcdi_mon.c
==============================================================================
--- stable/12/sys/dev/sfxge/common/mcdi_mon.c	Fri Dec 21 16:02:29 2018	(r342324)
+++ stable/12/sys/dev/sfxge/common/mcdi_mon.c	Fri Dec 21 16:06:25 2018	(r342325)
@@ -265,7 +265,6 @@ mcdi_mon_ev(
 	__out				efx_mon_stat_value_t *valuep)
 {
 	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);
-	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);
 	uint16_t port_mask;
 	uint16_t sensor;
 	uint16_t state;
@@ -281,11 +280,13 @@ mcdi_mon_ev(
 	value = (uint16_t)MCDI_EV_FIELD(eqp, SENSOREVT_VALUE);
 
 	/* Hardware must support this MCDI sensor */
-	EFSYS_ASSERT3U(sensor, <, (8 * encp->enc_mcdi_sensor_mask_size));
+	EFSYS_ASSERT3U(sensor, <,
+	    (8 * enp->en_nic_cfg.enc_mcdi_sensor_mask_size));
 	EFSYS_ASSERT((sensor % MCDI_MON_PAGE_SIZE) != MC_CMD_SENSOR_PAGE0_NEXT);
-	EFSYS_ASSERT(encp->enc_mcdi_sensor_maskp != NULL);
-	EFSYS_ASSERT((encp->enc_mcdi_sensor_maskp[sensor / MCDI_MON_PAGE_SIZE] &
-		(1U << (sensor % MCDI_MON_PAGE_SIZE))) != 0);
+	EFSYS_ASSERT(enp->en_nic_cfg.enc_mcdi_sensor_maskp != NULL);
+	EFSYS_ASSERT(
+	    (enp->en_nic_cfg.enc_mcdi_sensor_maskp[sensor/MCDI_MON_PAGE_SIZE] &
+	    (1U << (sensor % MCDI_MON_PAGE_SIZE))) != 0);
 
 	/* But we don't have to understand it */
 	if (sensor >= EFX_ARRAY_SIZE(mcdi_sensor_map)) {

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201812211606.wBLG6P9R068744>