From owner-freebsd-stable@freebsd.org Wed Nov 13 08:21:32 2019 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 961D61AA485 for ; Wed, 13 Nov 2019 08:21:32 +0000 (UTC) (envelope-from freebsd-lists-5@thismonkey.com) Received: from mail-01.thismonkey.com (mail-01.thismonkey.com [220.244.217.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "thismonkey.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47Ccyd20qcz3FVR; Wed, 13 Nov 2019 08:21:28 +0000 (UTC) (envelope-from freebsd-lists-5@thismonkey.com) X-TM-Via-MX: mail-01.thismonkey.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thismonkey.com; s=mail-01; t=1573633276; bh=GJr0uG7z3Ni0rDJ5ps95vcrnfzzYBfLLEeLDAXAAuQU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=CtOfcLfI7isilSGaOYHHVJ5Wa+YiYWilfAvULIu3CuTBSn4hSY5aViyCRo1ngER0A Z7IOLOtSpwSH9Nyy3N13zyrncNWRlGq4HCB/f3JjUMnU/0ZEdB/TIL8LizT4JzWNle 3Op5fMoTCCfmcRE5BOumSY0JQ50AcQZOhxdPLICQ= Received: from utility-01.thismonkey.com (utility-01.thismonkey.com [10.1.1.32]) by mail-01.thismonkey.com (8.15.2/8.15.2) with ESMTPS id xAD8LFQl032892 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Nov 2019 19:21:16 +1100 (EST) (envelope-from freebsd-lists-5@thismonkey.com) Received: from utility-01.thismonkey.com (localhost [127.0.0.1]) by utility-01.thismonkey.com (8.15.2/8.15.2) with ESMTP id xAD8LFPt076688; Wed, 13 Nov 2019 19:21:15 +1100 (EST) (envelope-from freebsd-lists-5@thismonkey.com) Received: (from root@localhost) by utility-01.thismonkey.com (8.15.2/8.15.2/Submit) id xAD8LEhj076665; Wed, 13 Nov 2019 19:21:14 +1100 (EST) (envelope-from freebsd-lists-5@thismonkey.com) Date: Wed, 13 Nov 2019 19:21:14 +1100 From: Scott To: Kubilay Kocak Cc: FreeBSD stable , Ed Schouten Subject: Re: syslogd truncating messages on FreeBSD >11.2-R Message-ID: <20191113082114.GA75711@thismonkey.com> Mail-Followup-To: Kubilay Kocak , FreeBSD stable , Ed Schouten References: <20191109030811.GA64882@thismonkey.com> <5265db9a-2eb2-6911-350a-aa1ed808da59@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5265db9a-2eb2-6911-350a-aa1ed808da59@FreeBSD.org> User-Agent: Mutt/1.11.4 (2019-03-13) X-Greylist: inspected by milter-greylist-4.6.2 (mail-01.thismonkey.com [10.1.2.50]); Wed, 13 Nov 2019 19:21:16 +1100 (EST) for IP:'10.1.1.32' DOMAIN:'utility-01.thismonkey.com' HELO:'utility-01.thismonkey.com' FROM:'freebsd-lists-5@thismonkey.com' RCPT:'' SPF:' X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mail-01.thismonkey.com [10.1.2.50]); Wed, 13 Nov 2019 19:21:16 +1100 (EST) X-Rspamd-Queue-Id: 47Ccyd20qcz3FVR X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=thismonkey.com header.s=mail-01 header.b=CtOfcLfI; dmarc=pass (policy=none) header.from=thismonkey.com; spf=pass (mx1.freebsd.org: domain of freebsd-lists-5@thismonkey.com designates 220.244.217.216 as permitted sender) smtp.mailfrom=freebsd-lists-5@thismonkey.com X-Spamd-Result: default: False [-2.80 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.99)[-0.992,0]; R_DKIM_ALLOW(-0.20)[thismonkey.com:s=mail-01]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+mx]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(0.19)[asn: 7545(0.96), country: AU(0.00)]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[thismonkey.com:+]; DMARC_POLICY_ALLOW(-0.50)[thismonkey.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:7545, ipnet:220.244.217.0/24, country:AU]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Nov 2019 08:21:32 -0000 Thanks all. Scott On Wed, Nov 13, 2019 at 05:11:51PM +1100, Kubilay Kocak wrote: > On 9/11/2019 2:08 pm, Scott wrote: > > Hi, > > > > please let me know if there is a better forum for this. > > > > As of 11.3-RELEASE syslogd truncates all forwarded messages to 480 bytes for > > IPV4 and 1180 for IPv6. > > > > The change occurs in the added code: > > > > switch (f->f_type) { > > case F_FORW: > > /* Truncate messages to RFC 5426 recommended size. */ > > dprintf(" %s", f->fu_forw_hname); > > switch (f->fu_forw_addr->ai_addr->sa_family) { > > #ifdef INET > > case AF_INET: > > dprintf(":%d\n", > > ntohs(satosin(f->fu_forw_addr->ai_addr)->sin_port)); > > iovlist_truncate(il, 480); > > break; > > #endif > > > > There's more code for IPv6 and the function iovlist_truncate itself. > > > > This change is not turned on by a switch and happens automatically, however I > > can't find it documented in UPDATING or the release notes. I would have > > thought that any change in default behaviour of the system should at least be > > documented. > > > > Ideally this change would have been implemented via a switch given that the > > RFC mentioned in the code (RFC 5426) does not mandate truncation, but > > recommends it when the network MTU is not known. > > > > What's the best way to reach out to the maintainer to suggest a switch to > > turn on this code? > > > > Thanks, > > Scott > > > Hi Scott, > > Looks like this came in in base r332510 [1] via: > > https://reviews.freebsd.org/D15011 > > The commit log message and review history may provide additional context > for the behaviour change (I haven't reviewed them) > > I have CC'd the committer on this email, but in the meantime, and if you > wouldn't mind, it is worth reporting the issue via Bugzilla, so that we > track it, and so others can find it. > > [1] https://svnweb.freebsd.org/changeset/base/332510 > > -- > Regards, > > koobs > > >