From owner-cvs-src@FreeBSD.ORG Wed May 28 15:16:49 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7529B106567B for ; Wed, 28 May 2008 15:16:49 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: from gv-out-0910.google.com (gv-out-0910.google.com [216.239.58.190]) by mx1.freebsd.org (Postfix) with ESMTP id EC9868FC23 for ; Wed, 28 May 2008 15:16:48 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: by gv-out-0910.google.com with SMTP id n8so880163gve.39 for ; Wed, 28 May 2008 08:16:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=Ifn/x8FbxxItiKC0BnH77yET9YV6YumD1eQor51lAkc=; b=pUQhekcs7aBoxSn5gGqDODep/TA80NbmzLkeT2iZJWzxzxVO/d+0T6CzSQ9cqVyaU6ogbNbaQmqglNuwp6WkuD4PJonKW2quS4PYrQw0aKohYNlFovrr2aI1/eP/uf8JloCM8UsfeX7mubWQ2jGma9MaIjQHMpBtgQuEHLINArM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=t/T4GlMge6TIt8hZPg9WbAbu3nC0FpgRNOeA9zGLVjLj/EsQzC3zTd7USyA8pTTCUg9IueJvwq3lBIZ4YcOgpG+rtoX5Da3qpimirQIjZvagVdlGFosv0qHNt0MXL7ZSLI2Vq1ejIp2HSaK4fqJuRn++DzZlf7O34RjRpw7lD0A= Received: by 10.78.206.6 with SMTP id d6mr1189997hug.46.1211987807281; Wed, 28 May 2008 08:16:47 -0700 (PDT) Received: by 10.78.136.16 with HTTP; Wed, 28 May 2008 08:16:47 -0700 (PDT) Message-ID: Date: Wed, 28 May 2008 17:16:47 +0200 From: "Antoine Brodin" Sender: antoine.brodin.freebsd@gmail.com To: "Bruce M. Simpson" In-Reply-To: <483D747C.6040008@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200805271833.m4RIXI2Y021272@repoman.freebsd.org> <1211975749.93683.21.camel@buffy.york.ac.uk> <483D747C.6040008@FreeBSD.org> X-Google-Sender-Auth: 8d4a9ba2892675ea Cc: cvs-src@freebsd.org, Gavin Atkinson , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/net if_media.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 May 2008 15:16:49 -0000 On Wed, May 28, 2008 at 5:04 PM, Bruce M. Simpson wrote: > Gavin Atkinson wrote: >> >> On Tue, 2008-05-27 at 18:33 +0000, Antoine Brodin wrote: >>> >>> MFC to RELENG_6: >>> Move "1000baseT" from IFM_SUBTYPE_ETHERNET_DESCRIPTIONS to >>> IFM_SUBTYPE_ETHERNET_ALIASES: there is already "1000baseTX" in >>> IFM_SUBTYPE_ETHERNET_DESCRIPTIONS. This doesn't change ifconfig >>> behaviour. >>> >> >> I'm not sure if this is any more correct than it was before. 1000baseT >> and 1000baseTX are incompatible standards. >> >> See http://docs.FreeBSD.org/cgi/mid.cgi?20050307191901.H32508 for an >> example of where this has come up before. The real bug is probably that >> we claim to support 1000baseTX at all. >> > > That sounds pretty clear to me. Perhaps this change should be backed out and > done the other way around (make 1000baseTX the alias) ? The goal of this commit was to have only one description instead of two (only the first one is printed by ifconfig and dmesg). So the commit didn't change the existing behaviour of ifconfig/dmesg. I can swap the two lines (make 1000baseT the description and 1000baseTX the alias), but it may break existing scripts that grep dmesg or ifconfig output for 1000baseTX. Cheers, Antoine