From owner-svn-src-all@freebsd.org Mon Jan 22 18:43:38 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0C225ECF417 for ; Mon, 22 Jan 2018 18:43:38 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: from mail-it0-f53.google.com (mail-it0-f53.google.com [209.85.214.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D0F6A68368 for ; Mon, 22 Jan 2018 18:43:37 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: by mail-it0-f53.google.com with SMTP id u62so11001595ita.2 for ; Mon, 22 Jan 2018 10:43:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:cc; bh=jE/Kjbu+DOTvsBLMHx2mpUGDeq+BWsHzyuCohIz62RM=; b=kv9ByHy9EscG5/c5aVVkdWHthGc6I7Ejajj20YOjqLF/qkopsYxC6NpOFuHFFSyT0C wPKnwctmkbHy9cyawUhItV0tf3Ra7EMR8V+1iVUYvLbKYrFPJvo51Y0IKrnmoVMbbdZ+ slsFrji3P54i/oYsDNEYKrKz8vkZUkT5YBoS/EErtK1I4D6ggRLBUzz62EY1HTmjRKTj g/trVkL7l9YD8FaO4vdUgQbzXuwHLYT3Om5l8hODjzsL27oJOPaoX/Ly+uGYeXdEXQRk GvqVhTwF31h55Ap2rxkMeieDtrttV3XX2yreYzy56EQEY1+iYxQT19PVrkoQLsIMAdlJ eZ7A== X-Gm-Message-State: AKwxyteJke/LXb5GkGT3SsVTTAhx/+JkclZ1oLJMXusY92IZalwFODhp LibjLWw96hy1Y0egOX4T7dSYn6Xe X-Google-Smtp-Source: AH8x225I0FjdXiauy4HMQ2yGwEHfOloH8GFerRufjHFHbD9QVPqOFAfRuRelF2lgIHWvRKAcgtHrpA== X-Received: by 10.36.104.210 with SMTP id v201mr8732921itb.64.1516646611140; Mon, 22 Jan 2018 10:43:31 -0800 (PST) Received: from mail-io0-f181.google.com (mail-io0-f181.google.com. [209.85.223.181]) by smtp.gmail.com with ESMTPSA id m82sm8192553ioe.36.2018.01.22.10.43.30 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jan 2018 10:43:31 -0800 (PST) Received: by mail-io0-f181.google.com with SMTP id p188so10450483ioe.12 for ; Mon, 22 Jan 2018 10:43:30 -0800 (PST) X-Received: by 10.107.20.200 with SMTP id 191mt10133122iou.239.1516646610576; Mon, 22 Jan 2018 10:43:30 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.157.12 with HTTP; Mon, 22 Jan 2018 10:43:10 -0800 (PST) In-Reply-To: <201801221840.w0MIeJls082586@repo.freebsd.org> References: <201801221840.w0MIeJls082586@repo.freebsd.org> From: Kyle Evans Date: Mon, 22 Jan 2018 12:43:10 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r328263 - head/lib/libregex Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2018 18:43:38 -0000 On Mon, Jan 22, 2018 at 12:40 PM, Kyle Evans wrote: > Author: kevans > Date: Mon Jan 22 18:40:19 2018 > New Revision: 328263 > URL: https://svnweb.freebsd.org/changeset/base/328263 > > Log: > libregex: Add a symbol map > > kib points out that trying to re-use symbol versioning from libc is dirty > and wrong. The implementation in libregex is incompatible by design with the > implementation in libc. Using the symbol versions from libc can and likely > will cause confusions for linkers and bring unexpected behavior for > consumers that unwillingly (transitively) link against libregex. > > Reported by: kib > Another thing I forgot to note here: libregex symbol versioning was actually not happening prior to this commit due to failure to define VERSION_DEF. This has also been corrected in this commit.