From owner-freebsd-stable@FreeBSD.ORG Tue Jan 26 15:37:57 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 878451065698; Tue, 26 Jan 2010 15:37:57 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 5BD158FC24; Tue, 26 Jan 2010 15:37:57 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 0E51846B2A; Tue, 26 Jan 2010 10:37:57 -0500 (EST) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPA id D348E8A024; Tue, 26 Jan 2010 10:37:55 -0500 (EST) From: John Baldwin To: freebsd-stable@freebsd.org Date: Tue, 26 Jan 2010 09:49:45 -0500 User-Agent: KMail/1.12.1 (FreeBSD/7.2-CBSD-20100120; KDE/4.3.1; amd64; ; ) References: <20100126092905.GA47528@m4-new.master-telecom.ru> In-Reply-To: <20100126092905.GA47528@m4-new.master-telecom.ru> MIME-Version: 1.0 Content-Type: Text/Plain; charset="koi8-r" Content-Transfer-Encoding: 7bit Message-Id: <201001260949.46082.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Tue, 26 Jan 2010 10:37:56 -0500 (EST) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: Dmitry Sivachenko , yongari@freebsd.org Subject: Re: RELENG_7 if_nve panic X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jan 2010 15:37:57 -0000 On Tuesday 26 January 2010 4:29:05 am Dmitry Sivachenko wrote: > Hello! > > I recompiled recent RELENG_7 and I get the following panic after > trying to kldload if_nve (interesting stack frames are 12, 13, 14 I guess). > Previous version of RELENG_7 (compiled in the middle of December) > worked fine. Last few days I was trying to re-cvsup and always get the > same panic. I get FreeBSD sources via cvsup (cvsup5.freebsd.org). > > Any suggestions? > > Thanks in advance! The bug is perhaps in e1000phy in that it expects all callers to have called if_initname() before the miibus is probed. Try this patch: Index: if_nve.c =================================================================== --- if_nve.c (revision 202705) +++ if_nve.c (working copy) @@ -526,14 +526,6 @@ goto fail; } - /* Probe device for MII interface to PHY */ - DEBUGOUT(NVE_DEBUG_INIT, "nve: do mii_phy_probe\n"); - if (mii_phy_probe(dev, &sc->miibus, nve_ifmedia_upd, nve_ifmedia_sts)) { - device_printf(dev, "MII without any phy!\n"); - error = ENXIO; - goto fail; - } - /* Setup interface parameters */ ifp->if_softc = sc; if_initname(ifp, device_get_name(dev), device_get_unit(dev)); @@ -549,6 +541,14 @@ ifp->if_capabilities |= IFCAP_VLAN_MTU; ifp->if_capenable |= IFCAP_VLAN_MTU; + /* Probe device for MII interface to PHY */ + DEBUGOUT(NVE_DEBUG_INIT, "nve: do mii_phy_probe\n"); + if (mii_phy_probe(dev, &sc->miibus, nve_ifmedia_upd, nve_ifmedia_sts)) { + device_printf(dev, "MII without any phy!\n"); + error = ENXIO; + goto fail; + } + /* Attach to OS's managers. */ ether_ifattach(ifp, eaddr); -- John Baldwin