Date: Wed, 30 Mar 2016 07:33:58 -0700 From: Nathan Whitehorn <nwhitehorn@freebsd.org> To: Zbigniew Bodek <zbb@semihalf.com>, Ed Maste <emaste@freebsd.org> Cc: Zbigniew Bodek <zbb@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r297392 - in head/sys: conf dev/ofw powerpc/mpc85xx powerpc/powermac powerpc/pseries Message-ID: <56FBE3D6.9050205@freebsd.org> In-Reply-To: <CAG7dG%2ByBOkHGoTxTWQ436jDpufHeDn3rSS%2B6ZoQCOG7O3HLjCQ@mail.gmail.com> References: <201603291519.u2TFJuXW051571@repo.freebsd.org> <CAPyFy2DCPvQ9ESC8FakSsZ=2kD2YkWieZhJiDC5RieSxFFrKqw@mail.gmail.com> <CAG7dG%2ByBOkHGoTxTWQ436jDpufHeDn3rSS%2B6ZoQCOG7O3HLjCQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
PowerPC (and SPARC) can have real OFW without FDT support. Adding FDT to LINT is the wrong solution: rather, it should switch on fdt | aim like the rest of the Open Firmware code. -Nathan On 03/30/16 01:54, Zbigniew Bodek wrote: > Hello Ed, > > Please check out the attached patch. For powerpc we should compile-in > ofwpci.c regardless of FDT option. > However, it seems that LINT for powerpc does not have FDT. What do you > thing about adding it (as can be seen in the attached patch)?. This > would be done in a separate commit. > > Best regards > zbb > > 2016-03-30 1:53 GMT+02:00 Ed Maste <emaste@freebsd.org > <mailto:emaste@freebsd.org>>: > > On 29 March 2016 at 15:19, Zbigniew Bodek <zbb@freebsd.org > <mailto:zbb@freebsd.org>> wrote: > > Author: zbb > > Date: Tue Mar 29 15:19:56 2016 > > New Revision: 297392 > > URL: https://svnweb.freebsd.org/changeset/base/297392 > > > > Log: > > Reduce OFW PCI code duplication - involves ARM, PPC and SPARC64 > > My 'make tinderbox' build is now failing (powerpc LINT) with: > > linking kernel > cpcht.o: In function `cpcht_attach': > cpcht.c:(.text+0x17dc): undefined reference to `ofw_pci_attach' > cpcht.o:(.data.rel+0x0): undefined reference to `ofw_pci_driver' > grackle.o: In function `grackle_attach': > grackle.c:(.text+0x2dc): undefined reference to `ofw_pci_attach' > grackle.o:(.data.rel+0x0): undefined reference to `ofw_pci_driver' > uninorthpci.o: In function `uninorth_attach': > uninorthpci.c:(.text+0x68c): undefined reference to `ofw_pci_attach' > uninorthpci.o:(.data.rel+0x0): undefined reference to `ofw_pci_driver' > *** [kernel] Error code 1 > _______________________________________________ > svn-src-all@freebsd.org <mailto:svn-src-all@freebsd.org> mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to > "svn-src-all-unsubscribe@freebsd.org > <mailto:svn-src-all-unsubscribe@freebsd.org>" > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56FBE3D6.9050205>