Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 11 Nov 2010 22:28:20 -0600
From:      Brandon Gooch <jamesbrandongooch@gmail.com>
To:        freebsd-stable@freebsd.org
Subject:   Re: New event timers for 8-STABLE [SEC=UNCLASSIFIED]
Message-ID:  <AANLkTi=JUx0cQxTkCGs0xVj8=WXXj_HUPK5fuTSm1ZeR@mail.gmail.com>
In-Reply-To: <20101112033008.GA47411@stlux503.dsto.defence.gov.au>
References:  <4CDC8CFC.8040402@FreeBSD.org> <20101112033008.GA47411@stlux503.dsto.defence.gov.au>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 11, 2010 at 9:30 PM, Wilkinson, Alex
<alex.wilkinson@dsto.defence.gov.au> wrote:
>
> =A0 =A00n Fri, Nov 12, 2010 at 02:40:28AM +0200, Alexander Motin wrote:
>
> =A0 =A0>I've created a patch, merging all kernel event timers related stu=
ff from
> =A0 =A0>HEAD to 8-STABLE. The only thing I have skipped at this moment wa=
s mips
> =A0 =A0>architecture, because of too big code difference there between HE=
AD and
> =A0 =A0>8-STABLE. Patch appeared to be quite large and includes more then=
 60 SVN
> =A0 =A0>revisions from HEAD. I hope I haven't missed anything important. =
I would
> =A0 =A0>like to ask interested people to test it. Patched code successful=
ly
> =A0 =A0>builds on all platforms and successfully runs on my amd64 test ma=
chine.
> =A0 =A0>
> =A0 =A0>In HEAD code seems to be working enough stable, There only two kn=
own
> =A0 =A0>open issues at the moment:
> =A0 =A0> - kernel freeze on XEN HVM when using LAPIC timer in one-shot mo=
de --
> =A0 =A0>can be workarounded by switching to periodic mode or other timer.
> =A0 =A0> - if HPET interrupt shared with other device, system load averag=
e may
> =A0 =A0>lie (report +1 value) -- not a timer problem and not fatal.
> =A0 =A0>Please report me if you find anything else.
> =A0 =A0>
> =A0 =A0>Latest patch can be found here:
> =A0 =A0>http://people.freebsd.org/~mav/timers_merge/timers_merge-20101111=
.patch
> =A0 =A0>
> =A0 =A0>Merge instructions (list of revisions, if somebody want to redo i=
t):
> =A0 =A0>http://people.freebsd.org/~mav/timers_merge/guide-20101111
> =A0 =A0>
> =A0 =A0>After patching you need just rebuild/reinstall the kernel. I have=
n't
> =A0 =A0>merged related manual pages yet, so, if needed, consult with man =
pages
> =A0 =A0>from HEAD: eventtimers(7), attimer(4), atrtc(4), hpet(4).
>
> patches apply cleanly but buildkernel fails:
>
> make -V CFILES -V SYSTEM_CFILES -V GEN_CFILES | =A0MKDEP_CPP=3D"cc -E" CC=
=3D"cc" xargs mkdep -a -f .newdep -O2 -pipe -fno-strict-aliasing -march=3Dn=
ocona -std=3Dc99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-proto=
types =A0-Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual =A0-Wund=
ef -Wno-pointer-sign -fformat-extensions -nostdinc =A0-I. -I/usr/src/sys -I=
/usr/src/sys/contrib/altq -I/usr/src/sys/contrib/ipfilter -I/usr/src/sys/co=
ntrib/pf -I/usr/src/sys/dev/ath -I/usr/src/sys/dev/ath/ath_hal -I/usr/src/s=
ys/contrib/ngatm -I/usr/src/sys/dev/twa -I/usr/src/sys/gnu/fs/xfs/FreeBSD -=
I/usr/src/sys/gnu/fs/xfs/FreeBSD/support -I/usr/src/sys/gnu/fs/xfs -I/usr/s=
rc/sys/contrib/opensolaris/compat -I/usr/src/sys/dev/cxgb -D_KERNEL -DHAVE_=
KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=3D80=
00 --param inline-unit-growth=3D100 --param large-function-growth=3D1000 =
=A0-fno-omit-frame-pointer -mcmodel=3Dkernel -mno-red-zone =A0-mfpmath=3D38=
7 -mno-sse -mno-sse2 -mno-sse3 -mno-mmx -mno-3dnow =A0-msoft-float -fno-asy=
nchronous-unwind-tables -ffreestanding -fstack-protector
> cc: /usr/src/sys/kern/kern_et.c: No such file or directory
> cc: /usr/src/sys/kern/kern_clocksource.c: No such file or directory
> /usr/src/sys/dev/acpica/acpi_hpet.c:46:24: error: sys/timeet.h: No such f=
ile or directory
> /usr/src/sys/x86/x86/local_apic.c:52:24: error: sys/timeet.h: No such fil=
e or directory
> /usr/src/sys/x86/isa/atrtc.c:45:24: error: sys/timeet.h: No such file or =
directory
> /usr/src/sys/x86/isa/clock.c:60:24: error: sys/timeet.h: No such file or =
directory
> mkdep: compile failed
> *** Error code 1
>
> Stop in /usr/obj/usr/src/sys/MARGS.
> *** Error code 1
>
> Stop in /usr/src.
> *** Error code 1
>
> Stop in /usr/src.
>

Revert the patch (patch -R) and reapply the patch with -p0:

[/usr/src]# patch -p0 < /path/to/file.patch

...and try it again :)

-Brandon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTi=JUx0cQxTkCGs0xVj8=WXXj_HUPK5fuTSm1ZeR>