From owner-freebsd-current@FreeBSD.ORG Tue Oct 16 11:29:13 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 550CE16A418 for ; Tue, 16 Oct 2007 11:29:13 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from gnome.kiev.sovam.com (gnome.kiev.sovam.com [212.109.32.24]) by mx1.freebsd.org (Postfix) with ESMTP id 0783113C48A for ; Tue, 16 Oct 2007 11:29:12 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from relay02.kiev.sovam.com ([62.64.120.197]) by gnome.kiev.sovam.com with esmtp (Exim 4.67 (FreeBSD)) (envelope-from ) id 1Ihkbn-0009Zx-VZ; Tue, 16 Oct 2007 14:29:11 +0300 Received: from [212.82.216.226] (helo=deviant.kiev.zoral.com.ua) by relay02.kiev.sovam.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.67) (envelope-from ) id 1Ihkbm-000FUI-Um; Tue, 16 Oct 2007 14:29:11 +0300 Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.1/8.14.1) with ESMTP id l9GBT7ZJ015938; Tue, 16 Oct 2007 14:29:07 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.1/8.14.1/Submit) id l9GBT7Tb015937; Tue, 16 Oct 2007 14:29:07 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 16 Oct 2007 14:29:07 +0300 From: Kostik Belousov To: avleeuwen@piwebs.com Message-ID: <20071016112907.GD6511@deviant.kiev.zoral.com.ua> References: <1191175387.92510.6.camel@shumai.marcuscom.com> <200710131857.46963.pieter@degoeje.nl> <471170E1.2090205@freebsd.org> <200710140408.46121.pieter@degoeje.nl> <471427BE.10500@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6WlEvdN9Dv0WHSBl" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Scanner-Signature: c6fa9c03b00bb8e85b0a425727b89505 X-DrWeb-checked: yes X-SpamTest-Envelope-From: kostikbel@gmail.com X-SpamTest-Group-ID: 00000000 X-SpamTest-Info: Profiles 1620 [Oct 16 2007] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {received from trusted relay: not dialup} X-SpamTest-Method: none X-SpamTest-Method: Local Lists X-SpamTest-Rate: 0 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release Cc: Pieter de Goeje , freebsd-current@freebsd.org, Rolf Witt Subject: Re: panic: ffs_blkfree: freeing free block X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 11:29:13 -0000 --6WlEvdN9Dv0WHSBl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 16, 2007 at 12:20:59PM +0200, Arjan van Leeuwen wrote: > 2007/10/16, Eric Anderson : > > > > Pieter de Goeje wrote: > > > On Sunday 14 October 2007, Eric Anderson wrote: > > >> Pieter de Goeje wrote: > > >>> On Saturday 13 October 2007, Rolf Witt wrote: > > >>>> Backtrace from crash tonight (after portsnap cron): > > >>> > > >>> > > >>>> # uname -a > > >>>> FreeBSD peanuts.homenet.local 7.0-PRERELEASE FreeBSD 7.0-PRERELEASE > > >>>> #121: Thu Oct 11 16:29:05 CEST 2007 > > >>>> rowi@peanuts.homenet.local:/usr/obj/usr/src/sys/PEANUTS i386 > > >>>> > > >>>> Sources from Builddate. > > >>>> > > >>>> Rowi > > >>> Eric sent me this patch: > > >>> http://www.googlebit.com/freebsd/patches/ffs_softdep.c-patch > > >>> which seems to be working great so far. I am still testing it, but I > > >>> think it fixed the problem. > > >>> To apply, cd /usr/src; patch < /path/to/patch and then rebuild the > > >>> kernel. > > >>> > > >>> Cheers, > > >>> Pieter de Goeje > > >> It doesn't actually 'fix' the problem, but I think it helps identify > > it. > > >> I'm not 100% certain if this is the right fix our not, but so far > > >> feedback has been good when running with this patch. > > >> > > >> Can somebody confirm that this patch is ok? > > >> > > >> Eric > > > Can you elaborate on what this patch exactly does / what the problem = is? > > > > > > Pieter > > > > > > I think the problem is that blocks are being put in the worklist twice, > > but I'm not certain why yet. The patch reduces the chance of this > > happening by more often removing the block from the worklist instead of > > leaving it on. I think actually the patch is hiding the real issue more > > than anything, which is why I said it isn't fixing the problem, but > > because of the reports I've seen, I think we're sniffing in the right > > area. I'll be looking more into this soon, when I get another few > > minutes of free time and my debugger.. >=20 > I actually seem to be getting the panic more often with the patch (i.e. > twice in just 30 minutes with the patch, about twice per day without the > patch), while doing the same things as usual. The panic usually happens w= hen > I'm compiling or linking. Is that strange? Patch is wrong. Actually, it does put the dirrem to the proccessing twice when xp !=3D NULL. --6WlEvdN9Dv0WHSBl Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFHFKCCC3+MBN1Mb4gRAsNrAKCKbJrbqCeM2k8lPBP0vSbww7vzjwCfSYOs kCgpk645xLBcU8KKN58zA28= =UEAb -----END PGP SIGNATURE----- --6WlEvdN9Dv0WHSBl--