Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 19 Feb 2017 22:42:31 +0100
From:      Oliver Pinter <oliver.pinter@hardenedbsd.org>
To:        Kurt Lidl <lidl@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org,  svn-src-head@freebsd.org
Subject:   Re: svn commit: r313965 - head/crypto/openssh
Message-ID:  <CAPQ4fftcvpWJ=5DG2YNUB4WQUzJPKa_Tzm28MvKrEFzC3dYqUg@mail.gmail.com>
In-Reply-To: <201702192035.v1JKZdie080791@repo.freebsd.org>
References:  <201702192035.v1JKZdie080791@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hello!

On 2/19/17, Kurt Lidl <lidl@freebsd.org> wrote:
> Author: lidl
> Date: Sun Feb 19 20:35:39 2017
> New Revision: 313965
> URL: https://svnweb.freebsd.org/changeset/base/313965
>
> Log:
>   Only notify blacklistd for successful logins in auth.c

What's the rationale behind this change?

>
>   Reported by:	Rick Adams
>   Reviewed by:	des
>   MFC after:	3 days
>   Sponsored by:	The FreeBSD Foundation
>
> Modified:
>   head/crypto/openssh/auth.c
>
> Modified: head/crypto/openssh/auth.c
> ==============================================================================
> --- head/crypto/openssh/auth.c	Sun Feb 19 19:56:12 2017	(r313964)
> +++ head/crypto/openssh/auth.c	Sun Feb 19 20:35:39 2017	(r313965)
> @@ -295,8 +295,8 @@ auth_log(Authctxt *authctxt, int authent
>  		authmsg = "Partial";
>  	else {
>  		authmsg = authenticated ? "Accepted" : "Failed";
> -		BLACKLIST_NOTIFY(authenticated ?
> -		    BLACKLIST_AUTH_OK : BLACKLIST_AUTH_FAIL);
> +		if (authenticated)
> +			BLACKLIST_NOTIFY(BLACKLIST_AUTH_OK);
>  	}
>
>  	authlog("%s %s%s%s for %s%.100s from %.200s port %d %s%s%s",
> _______________________________________________
> svn-src-head@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/svn-src-head
> To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org"
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPQ4fftcvpWJ=5DG2YNUB4WQUzJPKa_Tzm28MvKrEFzC3dYqUg>