From owner-freebsd-current Tue Dec 17 11:31:51 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6E70437B401 for ; Tue, 17 Dec 2002 11:31:50 -0800 (PST) Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id D2C4043EDE for ; Tue, 17 Dec 2002 11:31:49 -0800 (PST) (envelope-from gallatin@cs.duke.edu) Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu [152.3.145.30]) by duke.cs.duke.edu (8.12.6/8.12.6) with ESMTP id gBHJVbro002397 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Tue, 17 Dec 2002 14:31:37 -0500 (EST) Received: (from gallatin@localhost) by grasshopper.cs.duke.edu (8.11.6/8.9.1) id gBHJVWb18486; Tue, 17 Dec 2002 14:31:32 -0500 (EST) (envelope-from gallatin@cs.duke.edu) From: Andrew Gallatin MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15871.31635.962334.855790@grasshopper.cs.duke.edu> Date: Tue, 17 Dec 2002 14:31:31 -0500 (EST) To: Kyunghwan Kim Cc: current@freebsd.org Subject: Re: INTR_MPSAFE to network device drivers In-Reply-To: <20021217191841.GA57094@ada.snu.ac.kr> References: <20021217191841.GA57094@ada.snu.ac.kr> X-Mailer: VM 6.75 under 21.1 (patch 12) "Channel Islands" XEmacs Lucid Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Kyunghwan Kim writes: > Is it okay to add INTR_MPSAFE for all INTR_TYPE_NET drivers? NO! > mbuf and bpf routines are all mp-safe, so it seems that > it is safe to make network device drivers out of Giant lock. > Or is there any unresolved related issues? Yes, the mbuf allocator must occasionally call kmem_malloc(), which requires Giant. This means no net driver can be made INTR_MPSAFE, or it will eventually panic when kmem_malloc is called. Drew To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message