From owner-freebsd-current@freebsd.org Wed Jun 1 08:54:01 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9058EB55E22 for ; Wed, 1 Jun 2016 08:54:01 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: from asp.reflexion.net (outbound-mail-211-190.reflexion.net [208.70.211.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 43AB91320 for ; Wed, 1 Jun 2016 08:54:00 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: (qmail 5546 invoked from network); 1 Jun 2016 08:54:24 -0000 Received: from unknown (HELO rtc-sm-01.app.dca.reflexion.local) (10.81.150.1) by 0 (rfx-qmail) with SMTP; 1 Jun 2016 08:54:24 -0000 Received: by rtc-sm-01.app.dca.reflexion.local (Reflexion email security v7.90.3) with SMTP; Wed, 01 Jun 2016 04:53:58 -0400 (EDT) Received: (qmail 2060 invoked from network); 1 Jun 2016 08:53:58 -0000 Received: from unknown (HELO iron2.pdx.net) (69.64.224.71) by 0 (rfx-qmail) with SMTP; 1 Jun 2016 08:53:58 -0000 X-No-Relay: not in my network X-No-Relay: not in my network X-No-Relay: not in my network Received: from [192.168.1.26] (c-76-115-7-162.hsd1.or.comcast.net [76.115.7.162]) by iron2.pdx.net (Postfix) with ESMTPSA id 70EB61C43E2; Wed, 1 Jun 2016 01:53:52 -0700 (PDT) Subject: Re: 11.0 -r300944 build*KERNEL* via amd64-gcc fails for: .../dev/cxgb/ulp/tom/cxgb_listen.c:926:13: error: redundant redeclaration of 'tcp_dooptions'; cxgbe has an issue too Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=us-ascii From: Mark Millard In-Reply-To: <20160601073612.GB4400@ox> Date: Wed, 1 Jun 2016 01:53:52 -0700 Cc: FreeBSD Current Content-Transfer-Encoding: quoted-printable Message-Id: <0090BCEC-2937-42EC-B875-A06018BEB55D@dsl-only.net> References: <1885ED2D-29CB-47EF-B746-7CAD52E91605@dsl-only.net> <086B90E6-2E0C-4AA9-B429-523685EF1459@dsl-only.net> <20160601073612.GB4400@ox> To: Navdeep Parhar X-Mailer: Apple Mail (2.3124) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jun 2016 08:54:01 -0000 On 2016-Jun-1, at 12:36 AM, Navdeep Parhar wrote: > On Tue, May 31, 2016 at 10:49:29PM -0700, Mark Millard wrote: >> On 2016-May-31, at 10:31 PM, Mark Millard = wrote: >>=20 > >>=20 >> If the offending declaration in cxgb_listen.c is commented out (or = removed) >> there is a "next problem" but for cxgbe: >>=20 >>> --- all_subdir_cxgbe/tom --- >>> /usr/src/sys/modules/cxgbe/tom/../../../dev/cxgbe/tom/t4_listen.c: = In function 'do_pass_accept_req': >>> = /usr/src/sys/modules/cxgbe/tom/../../../dev/cxgbe/tom/t4_listen.c:640:1: = warning: inlining failed in call to 'release_synqe': call is unlikely = and code size would grow [-Winline] >=20 > Can you try removing the "inline" at line 639 in t4_listen.c and see = if that > makes a difference? >=20 > Regards, > Navdeep I tried commenting out the inline. Looks like cxgbe code has the same sort of redundant declaration problem = as cxgb code: > --- t4_listen.o --- > = /usr/src/sys/modules/cxgbe/tom/../../../dev/cxgbe/tom/t4_listen.c:669:13: = error: redundant redeclaration of 'tcp_dooptions' = [-Werror=3Dredundant-decls] > extern void tcp_dooptions(struct tcpopt *, u_char *, int, int); > ^ > In file included from = /usr/src/sys/modules/cxgbe/tom/../../../dev/cxgbe/tom/t4_listen.c:61:0: > /usr/src/sys/netinet/tcp_var.h:769:7: note: previous declaration of = 'tcp_dooptions' was here > void tcp_dooptions(struct tcpopt *, u_char *, int, int); > ^ . . . > --- t4_listen.o --- > cc1: all warnings being treated as errors > *** [t4_listen.o] Error code 1 Commenting that out as well lead to a failure in a very different area = of code: > --- all_subdir_drm2/i915kms --- > In file included from = /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/intel_drv.h:31:0,= > from = /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/dvo.h:35, > from = /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/dvo_ch7xxx.c:32: > /usr/src/sys/dev/drm2/i915/i915_drv.h:1621:6: error: redundant = redeclaration of 'i915_gem_dump_object' [-Werror=3Dredundant-decls] > void i915_gem_dump_object(struct drm_i915_gem_object *obj, int len, > ^ > /usr/src/sys/dev/drm2/i915/i915_drv.h:1612:6: note: previous = declaration of 'i915_gem_dump_object' was here > void i915_gem_dump_object(struct drm_i915_gem_object *obj, int len, > ^ > In file included from = /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/dvo.h:35:0, > from = /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/dvo_ch7xxx.c:32: > = /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/intel_drv.h:671:1= 3: error: redundant redeclaration of 'intel_fbc_enabled' = [-Werror=3Dredundant-decls] > extern bool intel_fbc_enabled(struct drm_device *dev); > ^ > In file included from = /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/intel_drv.h:31:0,= > from = /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/dvo.h:35, > from = /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/dvo_ch7xxx.c:32: > /usr/src/sys/dev/drm2/i915/i915_drv.h:1676:13: note: previous = declaration of 'intel_fbc_enabled' was here > extern bool intel_fbc_enabled(struct drm_device *dev); > ^ . . . > --- all_subdir_drm2 --- > cc1: all warnings being treated as errors > *** [dvo_ch7xxx.o] Error code 1 =3D=3D=3D Mark Millard markmi at dsl-only.net