Date: Tue, 24 Apr 2018 00:54:07 +0200 From: Mateusz Piotrowski <0mp@FreeBSD.org> To: Kevin Oberman <rkoberman@gmail.com> Cc: "O. Hartmann" <ohartmann@walstatt.org>, Mariusz Zaborski <oshogbo@freebsd.org>, Tommi Pernila <tommi.pernila@iki.fi>, FreeBSD Current <freebsd-current@freebsd.org>, freebsd-desktop@freebsd.org Subject: Re: Nvidia issue with CURRENT Message-ID: <20180424005407.473fd145@oxy> In-Reply-To: <CAN6yY1toqLWGvdVhe3v63T7BnKjoQAFVYYLqbb5pTn%2BjxeGhgg@mail.gmail.com> References: <CAGOYWV9HifEC_rgodotLijdAgG669X2%2BwZ5rVqRrsoDnZK0QtQ@mail.gmail.com> <CABHD1wSKWSDgjqvfpeDCX9b38PkFJb=ESSskkD3C5q%2BKU3zRvA@mail.gmail.com> <CAGOYWV_no6H=8ymkeVU40V9ftVtONydOcfEwYseeNYnd9t6=Qg@mail.gmail.com> <20180423090033.70a5ed85@freyja.zeit4.iv.bundesimmobilien.de> <20180423105326.63b32e2b@oxy> <CAN6yY1toqLWGvdVhe3v63T7BnKjoQAFVYYLqbb5pTn%2BjxeGhgg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 23 Apr 2018 08:19:25 -0700 Kevin Oberman <rkoberman@gmail.com> wrote: >On Mon, Apr 23, 2018 at 1:53 AM, Mateusz Piotrowski <0mp@freebsd.org> >wrote: > >> On Mon, 23 Apr 2018 09:00:33 +0200 >> "O. Hartmann" <ohartmann@walstatt.org> wrote: >> >> >In /etc/src.conf , therefore you should add something similar to >> >(like I added to mine): >> > >> >PORTS_MODULES= >> >PORTS_MODULES+= x11/nvidia-driver >> >PORTS_MODULES+= >> >emulators/virtualbox-ose-kmod >> >> Shouldn't it go into make.conf(5)? That's what the manual suggests. >> > >Ans the man page should be fixed. By putting it into make.conf, it >pollutes the environment of ever make(1) run on the system. (Yes, >unlikely to ever cause a problem,) > >In src.conf it only impacts the builds of the system and ports. This >is why src.conf was created a few years ago. In fact, it was >originally supposed to only impact the build of the system, but the >ports Mk files were modified to pull it in, to, much to my annoyance. >I liked being able to modify compile options just for the system >without them breaking ports builds. > >Simple rule... any definition used by make(1) only for system builds >belongs in /etc/sec.conf. Done, I've added this information to make.conf(5). Now it's waiting for a review. https://reviews.freebsd.org/D15177 Thanks! Mateusz
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180424005407.473fd145>