From owner-freebsd-stable@FreeBSD.ORG Tue Jan 26 15:53:03 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B979D1065670; Tue, 26 Jan 2010 15:53:03 +0000 (UTC) (envelope-from mitya@m4-new.master-telecom.ru) Received: from m4-new.master-telecom.ru (m4-new.master-telecom.ru [85.193.64.114]) by mx1.freebsd.org (Postfix) with ESMTP id 2651C8FC14; Tue, 26 Jan 2010 15:53:01 +0000 (UTC) Received: from m4-new.master-telecom.ru (localhost [127.0.0.1]) by m4-new.master-telecom.ru (8.13.8/8.13.8) with ESMTP id o0QFr0pC088450; Tue, 26 Jan 2010 18:53:00 +0300 (MSK) (envelope-from mitya@m4-new.master-telecom.ru) Received: (from mitya@localhost) by m4-new.master-telecom.ru (8.13.8/8.13.8/Submit) id o0QFr074088449; Tue, 26 Jan 2010 18:53:00 +0300 (MSK) (envelope-from mitya) Date: Tue, 26 Jan 2010 18:53:00 +0300 From: Dmitry Sivachenko To: John Baldwin Message-ID: <20100126155300.GA87838@m4-new.master-telecom.ru> References: <20100126092905.GA47528@m4-new.master-telecom.ru> <201001260949.46082.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <201001260949.46082.jhb@freebsd.org> WWW-Home-Page: http://mitya.pp.ru/ X-PGP-Key: http://mitya.pp.ru/mitya.asc User-Agent: Mutt/1.5.18 (2008-05-17) Cc: freebsd-stable@freebsd.org, yongari@freebsd.org Subject: Re: RELENG_7 if_nve panic X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jan 2010 15:53:03 -0000 On Tue, Jan 26, 2010 at 09:49:45AM -0500, John Baldwin wrote: > On Tuesday 26 January 2010 4:29:05 am Dmitry Sivachenko wrote: > > Hello! > > > > I recompiled recent RELENG_7 and I get the following panic after > > trying to kldload if_nve (interesting stack frames are 12, 13, 14 I guess). > > Previous version of RELENG_7 (compiled in the middle of December) > > worked fine. Last few days I was trying to re-cvsup and always get the > > same panic. I get FreeBSD sources via cvsup (cvsup5.freebsd.org). > > > > Any suggestions? > > > > Thanks in advance! > > The bug is perhaps in e1000phy in that it expects all callers to have called > if_initname() before the miibus is probed. Try this patch: That patch solves the problem, thanks! > > Index: if_nve.c > =================================================================== > --- if_nve.c (revision 202705) > +++ if_nve.c (working copy) > @@ -526,14 +526,6 @@ > goto fail; > } > > - /* Probe device for MII interface to PHY */ > - DEBUGOUT(NVE_DEBUG_INIT, "nve: do mii_phy_probe\n"); > - if (mii_phy_probe(dev, &sc->miibus, nve_ifmedia_upd, nve_ifmedia_sts)) { > - device_printf(dev, "MII without any phy!\n"); > - error = ENXIO; > - goto fail; > - } > - > /* Setup interface parameters */ > ifp->if_softc = sc; > if_initname(ifp, device_get_name(dev), device_get_unit(dev)); > @@ -549,6 +541,14 @@ > ifp->if_capabilities |= IFCAP_VLAN_MTU; > ifp->if_capenable |= IFCAP_VLAN_MTU; > > + /* Probe device for MII interface to PHY */ > + DEBUGOUT(NVE_DEBUG_INIT, "nve: do mii_phy_probe\n"); > + if (mii_phy_probe(dev, &sc->miibus, nve_ifmedia_upd, nve_ifmedia_sts)) { > + device_printf(dev, "MII without any phy!\n"); > + error = ENXIO; > + goto fail; > + } > + > /* Attach to OS's managers. */ > ether_ifattach(ifp, eaddr); > > > -- > John Baldwin