Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 21 May 2019 05:20:47 +1000
From:      Peter Jeremy <peter@rulingia.com>
To:        Conrad Meyer <cem@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r347984 - in head/sys: amd64/vmm/io arm/allwinner arm/allwinner/a10 arm/allwinner/clkng arm/arm arm/broadcom/bcm2835 arm/freescale/imx arm/mv arm/mv/armada arm/nvidia arm/nvidia/tegra12...
Message-ID:  <20190520192047.GA3524@server.rulingia.com>
In-Reply-To: <201905200038.x4K0cNoZ019920@repo.freebsd.org>
References:  <201905200038.x4K0cNoZ019920@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--0OAP2g/MAC+5xKAE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2019-May-20 00:38:23 +0000, Conrad Meyer <cem@FreeBSD.org> wrote:
>Author: cem
>Date: Mon May 20 00:38:23 2019
>New Revision: 347984
>URL: https://svnweb.freebsd.org/changeset/base/347984
>
>Log:
>  Extract eventfilter declarations to sys/_eventfilter.h
=2E..
>  No functional change (intended).  Of course, any out of tree modules that
>  relied on header pollution for sys/eventhandler.h, sys/lock.h, or
>  sys/mutex.h inclusion need to be fixed.  __FreeBSD_version has been bump=
ed.

This seems to have broken at least netmap and netdump for me:
/usr/src/sys/dev/netmap/netmap_freebsd.c:191:3: error: implicit declaration=
 of function 'EVENTHANDLER_REGISTER' is invalid in C99 [-Werror,-Wimplicit-=
function-declaration]
                EVENTHANDLER_REGISTER(ifnet_arrival_event,
                ^
=2E..
/usr/src/sys/netinet/netdump/netdump_client.c:1458:22: error: implicit decl=
aration of function 'EVENTHANDLER_REGISTER' is invalid in C99 [-Werror,-Wim=
plicit-function-declaration]
                nd_detach_cookie =3D EVENTHANDLER_REGISTER(ifnet_departure_=
event,
                                   ^

--=20
Peter Jeremy

--0OAP2g/MAC+5xKAE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEE7rKYbDBnHnTmXCJ+FqWXoOSiCzQFAlzi/g9fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVF
QjI5ODZDMzA2NzFFNzRFNjVDMjI3RTE2QTU5N0EwRTRBMjBCMzQACgkQFqWXoOSi
CzRm7A//Xu2bpx8pXREMW4pkZQU14IyPOi8//EFHhwFwGB/RNoQDe6LShG8Pus+Y
PDUjInx0D2sTDS38XRVszmo9Qr+gZ75pkT2wSdHlxoxsrySdhtwDGX0Ro79D73HL
TWzGODlm5gn2JOutPha7R6PFh4blFAEFUkPPhTWwKnGpJIuAtlzwuxw9c5DBPu2O
r692fGHjKUUz/z6Mkl0RPUAGNtRdRQ+Ath3Fgn48a/w92FuE9XNXJAGpYuKbV9DS
2pPvfuKEXC4n5rr75cvwcJkYC+CfS4UFFWGuPzHeAJ9zE7Uyj9s2xM/7NyWpGyZy
EyY9Ui8Y7MlliZxGbjg4WitNVDoeu3xaGE8bUEEgmWeHhSdBPPDa2AoA2cD8lr9i
j9UWDmRG6Q5O9LCrHgOEewpimnISYV/Xl+1A0HMQxsN1hy3TtNgEuUEVNagDuFPz
lh9TtAJyPpsl28xQp9L8kR+gmC71oxNBnW/5ygFHxDmZ75uz8fMMSLwJ8+5aAw6X
8LkgX00bu5Twl/TRl94MwvXBLbwiGn+Y5RfW53uYU39hWyaIQ3ufedabq+12bl66
K27/Go+Y871vKM+Hh9ginp4/h5wRJ4sIluC1xBisiOwbfBACgu191ag+RQuQXHOb
l4sEDaN+QZbcYJxCbksyzU9A2zbSNEJfsFiv3uA6bLo6QVB+0qI=
=bl+S
-----END PGP SIGNATURE-----

--0OAP2g/MAC+5xKAE--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190520192047.GA3524>